Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Connectedmachine] Added a property in az connectedmachine extension create/update #4013

Merged
merged 15 commits into from
Oct 28, 2021

Conversation

dorothyhu
Copy link
Contributor


This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your PR is merged into master branch, a new PR will be created to update src/index.json automatically.
The precondition is to put your code inside this repo and upgrade the version in the PR but do not modify src/index.json.

@yonzhan
Copy link
Collaborator

yonzhan commented Oct 22, 2021

Connectedmachine

@zhoxing-ms
Copy link
Contributor

If you want to upgrade a new version to release this change, please update the setup.py file

@zhoxing-ms
Copy link
Contributor

Could you add some tests for this new parameter?

@zhoxing-ms
Copy link
Contributor

  • FAIL - HIGH severity: option_length_too_long
    Parameter: connectedmachine extension create, enable_automatic_upgrade - The lengths of all options ['--enable-automatic-upgrade'] are longer than threshold 22. Argument enable_automatic_upgrade must have a short abbreviation.
    Parameter: connectedmachine extension update, enable_automatic_upgrade - The lengths of all options ['--enable-automatic-upgrade'] are longer than threshold 22. Argument enable_automatic_upgrade must have a short abbreviation.

Could you please address the linter issues? You need to consider adding a short alias for this parameter

@zhoxing-ms zhoxing-ms merged commit ad1897f into Azure:main Oct 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants