Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

switch to 2019-04-01 api version and enable windows agent pool #612

Merged
merged 6 commits into from
Apr 4, 2019
Merged

switch to 2019-04-01 api version and enable windows agent pool #612

merged 6 commits into from
Apr 4, 2019

Conversation

xizha162
Copy link
Contributor

vendor in 2019-04-01 SDK
added support for passing in windows username and password
removed the parenthesis from the list of special chars for auto service principal secret generation due to an issue in windows pool provisioning powershell script
Added node count verification for agentpool scale command

This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • Have you run ./scripts/ci/test_static.sh locally? (pip install pylint flake8 required)
  • Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

tjprescott
tjprescott suggested changes Apr 2, 2019
View reviewed changes
src/aks-preview/azext_aks_preview/custom.py Outdated
@@ -420,6 +423,15 @@ def aks_create(cmd, client, resource_group_name, name, ssh_key_value, # pylint:
public_keys=[ContainerServiceSshPublicKey(key_data=ssh_key_value)])
linux_profile = ContainerServiceLinuxProfile(admin_username=admin_username, ssh=ssh_config)

windows_profile = None
if (windows_admin_username is None) != (windows_admin_password is None):
raise CLIError("Please make sure both windows admin username and password are specified.")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The idiomatic error here would be:
usage error: --windows-admin-username NAME --windows-password PASSWORD

Does the command allow secure prompting for the password?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tjprescott Added secure prompt for windows password. Please take a look.

src/aks-preview/azext_aks_preview/custom.py
from .vendored_sdks.azure_mgmt_preview_aks.v2019_04_01.models import ManagedClusterAddonProfile
from .vendored_sdks.azure_mgmt_preview_aks.v2019_04_01.models import ManagedClusterAgentPoolProfile
from .vendored_sdks.azure_mgmt_preview_aks.v2019_04_01.models import AgentPool
from .vendored_sdks.azure_mgmt_preview_aks.v2019_04_01.models import ContainerServiceStorageProfileTypes
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are we still writing these import statements with the version hard-coded? This should be using the CLI's profile mechanisms and cmd.get_models(...)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right now, we haven't refactored the code, but should be done in near future. Since it is aks-preview, we should be ok to use the hard-coded version.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can refer this PR to refactor Azure/azure-cli#8331

zqingqing1
zqingqing1 approved these changes Apr 4, 2019
View reviewed changes
Copy link
Member

@zqingqing1 zqingqing1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@tjprescott tjprescott merged commit de4a2ea into Azure:master Apr 4, 2019
tamirkamara pushed a commit to tamirkamara/azure-cli-extensions that referenced this pull request May 3, 2019
@tamirkamara
switch to 2019-04-01 api version and enable windows agent pool (Azure…
859275d 
…#612)

* fixing az support for agent pools and mc

* vendor in 2019-04-01 SDK

* enableing windows profile

* merge the latest official SDK

* add secure prompt for windows admin password

* fixing warnings
tjprescott pushed a commit that referenced this pull request May 7, 2019
@tamirkamara @tjprescott
[image-copy] update to version 0.2.1 (#669)
5709e08 
* [image-copy] update to version 0.2.0

* [image-copy] update index for version 0.2.0

* switch to 2019-04-01 api version and enable windows agent pool (#612)

* fixing az support for agent pools and mc

* vendor in 2019-04-01 SDK

* enableing windows profile

* merge the latest official SDK

* add secure prompt for windows admin password

* fixing warnings

* Policies should be global, remove location parameter and default it (#620)

* bug fixes: missing service principal and network profile parameter validation (#626)

* Pin max CLI version. (#630)

* Update front door index to 0.1.5 (#632)

* Fixes #629. (#631)

* Update index.json. (#640)

* Add new version of aks-preview in index.json (#634)

* Azure Event Grid 0.4.1 (#633)

* Azure Event Grid 0.4.1

* fix white space

* fix style issues

* style fixes

* style comment spaces fixes

* more style fixes

* mossing hesder

* Address CR comment

* move json generated SDK files to vendored_sdks folder and update related imports

* revert index changes until we publish final extension

* Address CR comments by removing unnecessary parameters

* Fix style

* update index.json file

* fix index.json after running azdev extension update-index

* fix index.json after running azdev extension update-index

* add missing __init__.py

* fix init files

* fix new line in init files

* update location of vendored_sdks and update index.json

* fix help errors and update index.json file accordingly

* [aks-preview]: fix python3-only super() syntax (#641)

* [storage-preview] release azcopy 10.0.9 (#639)

* [storage-preview] release azcopy 10.0.9

* Fix indent

* [storage-preview] pulish 0.2.4 (#642)

* App Insights control plane (#600)

* Remove 'preview' from Dev Spaces (#638)

* Update PULL_REQUEST_TEMPLATE.md (#645)

Refer to azdev.

* setting default vm size for windows (#637)

* SQL: make "up" command work end to end (#644)

* Update requirements.txt

Bump for Jinja security vulnerability

* Update to RP standard release 3.5 (#29) (#627)

* NFSAAS-2102 update to R3.5 (#29)

* Nfsaas 2102 update to r3 5 (#30)

* NFSAAS-2102 update to R3.5

* NFSAAS-2102 update to RP R3.5 standard

* Nfsaas 2102 update to r3 5 (#31)

* NFSAAS-2102 update to R3.5

* NFSAAS-2102 update to RP R3.5 standard

* NFSAAS-2102 update to R3.5 RP standard

* Nfsaas 2102 update to r3 5 (#32)

* NFSAAS-2102 update to R3.5

* NFSAAS-2102 update to RP R3.5 standard

* NFSAAS-2102 update to R3.5 RP standard

* NFSAAS-2102 update to R3.5 RP standard

* Nfsaas 2102 update to r3 5 (#33)

* NFSAAS-2102 update to R3.5

* NFSAAS-2102 update to RP R3.5 standard

* NFSAAS-2102 update to R3.5 RP standard

* NFSAAS-2102 update to R3.5 RP standard

* NFSAAS-2102 update to R3.5 RP standard

* Nfsaas 2102 update to r3 5 (#34)

* NFSAAS-2102 update to R3.5

* NFSAAS-2102 update to RP R3.5 standard

* NFSAAS-2102 update to R3.5 RP standard

* NFSAAS-2102 update to R3.5 RP standard

* NFSAAS-2102 update to R3.5 RP standard

* NFSAAS-2102 update to R3.5 RP standard

* Nfsaas 2102 update to r3 5 (#35)

* NFSAAS-2102 update to R3.5

* NFSAAS-2102 update to RP R3.5 standard

* NFSAAS-2102 update to R3.5 RP standard

* NFSAAS-2102 update to R3.5 RP standard

* NFSAAS-2102 update to R3.5 RP standard

* NFSAAS-2102 update to R3.5 RP standard

* NFSAAS-2102 update to R3.5 RP standard

* Nfsaas 2102 update to r3 5 (#36)

* NFSAAS-2102 update to R3.5

* NFSAAS-2102 update to RP R3.5 standard

* NFSAAS-2102 update to R3.5 RP standard

* NFSAAS-2102 update to R3.5 RP standard

* NFSAAS-2102 update to R3.5 RP standard

* NFSAAS-2102 update to R3.5 RP standard

* NFSAAS-2102 update to R3.5 RP standard

* NFSAAS-2102 update to R3.5 RP standard

* Nfsaas 2102 update to r3 5 (#37)

* NFSAAS-2102 update to R3.5

* NFSAAS-2102 update to RP R3.5 standard

* NFSAAS-2102 update to R3.5 RP standard

* NFSAAS-2102 update to R3.5 RP standard

* NFSAAS-2102 update to R3.5 RP standard

* NFSAAS-2102 update to R3.5 RP standard

* NFSAAS-2102 update to R3.5 RP standard

* NFSAAS-2102 update to R3.5 RP standard

* NFSAAS-2102 update to R3.5 RP standard

* Nfsaas 2102 update to r3 5 (#38)

* NFSAAS-2102 update to R3.5

* NFSAAS-2102 update to RP R3.5 standard

* NFSAAS-2102 update to R3.5 RP standard

* NFSAAS-2102 update to R3.5 RP standard

* NFSAAS-2102 update to R3.5 RP standard

* NFSAAS-2102 update to R3.5 RP standard

* NFSAAS-2102 update to R3.5 RP standard

* NFSAAS-2102 update to R3.5 RP standard

* NFSAAS-2102 update to R3.5 RP standard

* NFSAAS-2102 update to R3.5 RP standard

* Nfsaas 2102 update to r3 5 (#39)

* NFSAAS-2102 update to R3.5

* NFSAAS-2102 update to RP R3.5 standard

* NFSAAS-2102 update to R3.5 RP standard

* NFSAAS-2102 update to R3.5 RP standard

* NFSAAS-2102 update to R3.5 RP standard

* NFSAAS-2102 update to R3.5 RP standard

* NFSAAS-2102 update to R3.5 RP standard

* NFSAAS-2102 update to R3.5 RP standard

* NFSAAS-2102 update to R3.5 RP standard

* NFSAAS-2102 update to R3.5 RP standard

* NFSAAS-2102 update to R3.5 RP standard

* Nfsaas 2102 update to r3 5 (#40)

* NFSAAS-2102 update to R3.5

* NFSAAS-2102 update to RP R3.5 standard

* NFSAAS-2102 update to R3.5 RP standard

* NFSAAS-2102 update to R3.5 RP standard

* NFSAAS-2102 update to R3.5 RP standard

* NFSAAS-2102 update to R3.5 RP standard

* NFSAAS-2102 update to R3.5 RP standard

* NFSAAS-2102 update to R3.5 RP standard

* NFSAAS-2102 update to R3.5 RP standard

* NFSAAS-2102 update to R3.5 RP standard

* NFSAAS-2102 update to R3.5 RP standard

* NFSAAS-2102 update to R3.5 RP standard

* Merge azure master back to fork. (#41)

* Add new version of aks-preview in index.json (#634)

* Azure Event Grid 0.4.1 (#633)

* Azure Event Grid 0.4.1

* fix white space

* fix style issues

* style fixes

* style comment spaces fixes

* more style fixes

* mossing hesder

* Address CR comment

* move json generated SDK files to vendored_sdks folder and update related imports

* revert index changes until we publish final extension

* Address CR comments by removing unnecessary parameters

* Fix style

* update index.json file

* fix index.json after running azdev extension update-index

* fix index.json after running azdev extension update-index

* add missing __init__.py

* fix init files

* fix new line in init files

* update location of vendored_sdks and update index.json

* fix help errors and update index.json file accordingly

* [aks-preview]: fix python3-only super() syntax (#641)

* [storage-preview] release azcopy 10.0.9 (#639)

* [storage-preview] release azcopy 10.0.9

* Fix indent

* [storage-preview] pulish 0.2.4 (#642)

* App Insights control plane (#600)

* Remove 'preview' from Dev Spaces (#638)

* Update PULL_REQUEST_TEMPLATE.md (#645)

Refer to azdev.

* setting default vm size for windows (#637)

* SQL: make "up" command work end to end (#644)

* Update requirements.txt

Bump for Jinja security vulnerability

* Update readme to reflect the latest SQL DB status

* SQL up: update a typo

* Update index.json for backwards compatability for Dev Spaces (#648)

* update index.json for backwards compatability

* fix maxCliVersion for dev-spaces-preview

* revert dev-spaces minCliCoreVersion

* update metadata for dev-spaces and dev-spaces-preview

* update metadata for dev-spaces and dev-spaces-preview

* sync workspaces

* 0.5.0 release for Azure DevOps (#653)

* [AKS]customizing node resource group (#636)

* customizing node resource group

* make 2.0 and 3.0 python work

* add index

* Onboard Azure Machine Learning Service CLI (#655)

* [storage-preview] pulish 0.2.5 (#657)

* [AKS] Add Azure policy addon (#651)

* Add the Azure Policy Addon Support

* Add azure-policy addon

* Allow azure-policy addon in create

* Update the index

* Add the missing parameter description

* 0.6.0 release for Azure DevOps (#660)

* Upgrade AppConfig extension version from 0.4.0 to 0.5.0 (#661)

* Upgrade AppConfig extension verstion from 0.4.0 to 0.5.0

* format downloadUrl

* update wheel version to 0.30.0

* Update service principal secret for windows nodes (#662)

* Release storage-preview 0.2.5 (#663)

* Remove extra + (#664)

* 0.7.0 release for Azure DevOps (#666)

* 0.7.0 release for Azure DevOps

* update sha

* fix

* remove botservice from index.json (#667)

* [image-copy] fix temp_rg default valuet
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zqingqing1 zqingqing1 zqingqing1 approved these changes

@tjprescott tjprescott tjprescott approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xizha162 @tjprescott @zqingqing1