Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Static CI checks #9

Merged
merged 2 commits into from
Nov 1, 2017
Merged

Static CI checks #9

merged 2 commits into from
Nov 1, 2017

Conversation

derekbekoe
Copy link
Member

  • Fix style of image-copy
  • Add PR template
  • Add license and codeowner checks
  • pylint/pep8

@derekbekoe
Static CI checks
45f0d10 
- Fix style of image-copy
- Add PR template
- Add license and codeowner checks
- pylint/pep8
@derekbekoe
Copy link
Member Author

cc: @tamirkamara to provide approval for style changes in your extension.
These changes are so extension source code is inline with the style expected in azure-cli.

@derekbekoe derekbekoe merged commit 4a81d88 into Azure:master Nov 1, 2017
@derekbekoe derekbekoe deleted the ci-source branch November 1, 2017 17:23
williexu pushed a commit that referenced this pull request Feb 28, 2019
@leonardbf @williexu
Create initial CLI Extension for ANF resource provider (#527)
5a82cfc 
* NFSAAS-1708 add initial version of anf cli extension

* NFSAAS-1708 lint fixes

* NFSAAS-1708 code owner

* NFSAAS-1708 update from review comments

* NFSAAS-1708 update from review comments

* NFSAAS-1708 update with code review comments

* NFSAAS-1708 updates from review comments

* NFSAAS-1708 updates from review comments

* NFSAAS-1708 updates from review comments (#9)

* Nfsaas 1708 initial cli extension (#10)

* NFSAAS-1708 updates from review comments

* NFSAAS-1708 updates from review comments

* Nfsaas 1708 initial cli extension (#11)

* NFSAAS-1708 updates from review comments

* NFSAAS-1708 updates from review comments

* NFSAAS-1708 updates from review comments

* Nfsaas 1708 initial cli extension (#13)

* NFSAAS-1708 updates from review comments

* NFSAAS-1708 updates from review comments

* NFSAAS-1708 updates from review comments

* NFSAAS-1708 updates from review comments

* Nfsaas 1708 initial cli extension (#14)

* NFSAAS-1708 updates from review comments

* NFSAAS-1708 updates from review comments

* NFSAAS-1708 updates from review comments

* NFSAAS-1708 updates from review comments

* NFSAAS-1708 updates from review comments

* Nfsaas 1708 initial cli extension (#16)

* NFSAAS-1708 updates from review comments

* NFSAAS-1708 updates from review comments

* NFSAAS-1708 updates from review comments

* NFSAAS-1708 updates from review comments

* NFSAAS-1708 updates from review comments

* NFSAAS-1708 updates from review comments

* Nfsaas 1708 initial cli extension (#17)

* NFSAAS-1708 updates from review comments

* NFSAAS-1708 updates from review comments

* NFSAAS-1708 updates from review comments

* NFSAAS-1708 updates from review comments

* NFSAAS-1708 updates from review comments

* NFSAAS-1708 updates from review comments

* NFSAAS-1708 updates from review comments
williexu pushed a commit that referenced this pull request Mar 4, 2019
@leonardbf @williexu
Add ANF service to CLI extension index (#551)
c254be9 
* NFSAAS-1708 add initial version of anf cli extension

* NFSAAS-1708 lint fixes

* NFSAAS-1708 code owner

* NFSAAS-1708 update from review comments

* NFSAAS-1708 update from review comments

* NFSAAS-1708 update with code review comments

* NFSAAS-1708 updates from review comments

* NFSAAS-1708 updates from review comments

* NFSAAS-1708 updates from review comments (#9)

* Nfsaas 1708 initial cli extension (#10)

* NFSAAS-1708 updates from review comments

* NFSAAS-1708 updates from review comments

* Nfsaas 1708 initial cli extension (#11)

* NFSAAS-1708 updates from review comments

* NFSAAS-1708 updates from review comments

* NFSAAS-1708 updates from review comments

* Nfsaas 1708 initial cli extension (#13)

* NFSAAS-1708 updates from review comments

* NFSAAS-1708 updates from review comments

* NFSAAS-1708 updates from review comments

* NFSAAS-1708 updates from review comments

* Nfsaas 1708 initial cli extension (#14)

* NFSAAS-1708 updates from review comments

* NFSAAS-1708 updates from review comments

* NFSAAS-1708 updates from review comments

* NFSAAS-1708 updates from review comments

* NFSAAS-1708 updates from review comments

* Nfsaas 1708 initial cli extension (#16)

* NFSAAS-1708 updates from review comments

* NFSAAS-1708 updates from review comments

* NFSAAS-1708 updates from review comments

* NFSAAS-1708 updates from review comments

* NFSAAS-1708 updates from review comments

* NFSAAS-1708 updates from review comments

* Nfsaas 1708 initial cli extension (#17)

* NFSAAS-1708 updates from review comments

* NFSAAS-1708 updates from review comments

* NFSAAS-1708 updates from review comments

* NFSAAS-1708 updates from review comments

* NFSAAS-1708 updates from review comments

* NFSAAS-1708 updates from review comments

* NFSAAS-1708 updates from review comments

* NFSAAS-1708 add anf to cli extension index

* NFSAAS-1708 add anf to cli extension index (#18)

* NFSAAS-1708 add ANF CLI extension to index

Plus correct some help validation errors

* NFSAAS-1708 add ANF CLI extension to index

Plus correct some help validation errors

* NFSAAS-1708 add ANF CLI extension to index (#22)

Plus correct some help validation errors

* Nfsaas 1708 add index (#23)

* NFSAAS-1708 add ANF CLI extension to index

Plus correct some help validation errors

* NFSAAS-1708 add ANF CLI extension to index

Plus correct some help validation errors

* Nfsaas 1708 add index (#24)

* NFSAAS-1708 add ANF CLI extension to index

Plus correct some help validation errors

* NFSAAS-1708 add ANF CLI extension to index

Plus correct some help validation errors

* NFSAAS-1708 add ANF CLI extension to index

Plus correct some help validation errors

* Nfsaas 1708 add index (#25)

* NFSAAS-1708 add ANF CLI extension to index

Plus correct some help validation errors

* NFSAAS-1708 add ANF CLI extension to index

Plus correct some help validation errors

* NFSAAS-1708 add ANF CLI extension to index

Plus correct some help validation errors

* NFSAAS-1708 add ANF CLI extension to index

Plus correct some help validation errors

* Nfsaas 1708 add index (#26)

* NFSAAS-1708 add ANF CLI extension to index

Plus correct some help validation errors

* NFSAAS-1708 add ANF CLI extension to index

Plus correct some help validation errors

* NFSAAS-1708 add ANF CLI extension to index

Plus correct some help validation errors

* NFSAAS-1708 add ANF CLI extension to index

Plus correct some help validation errors

* NFSAAS-1708 add ANF CLI extension to index

Plus correct some help validation errors

* Nfsaas 1708 add index (#27)

* NFSAAS-1708 add ANF CLI extension to index

Plus correct some help validation errors

* NFSAAS-1708 add ANF CLI extension to index

Plus correct some help validation errors

* NFSAAS-1708 add ANF CLI extension to index

Plus correct some help validation errors

* NFSAAS-1708 add ANF CLI extension to index

Plus correct some help validation errors

* NFSAAS-1708 add ANF CLI extension to index

Plus correct some help validation errors

* NFSAAS-1708 add ANF CLI extension to index

Plus correct some help validation errors
changlong-liu added a commit to changlong-liu/azure-cli-extensions that referenced this pull request Nov 27, 2020
@changlong-liu
20201124 refactor test (Azure#9)
7b48c47 
* add option_list (Azure#3)

* manual test

* datafactory

* kusto
qwordy added a commit that referenced this pull request Feb 1, 2021
@anpaz @ricardo-espinoza @qwordy
Creating CLI extension for Azure Quantum (#1879)
12f5b10 
* Azure quantum extension v0 (#2)

Initial version.

* Fixing style issues

* Incorporating feedback (#6)

* readme
* feedback

* Help

* Make storage account optional (#7)

* Storage is now optional (#8)

* Making storage an argument, not an env variable (#9)

* Adding implementation of 'az quantum workspace delete' command.

* Setting new temporary version.

* Fixing missing file in test change

* Adding details to README.md (#5)

* Updating generated files for Azure Quantum resource manager from new swagger file version

* Remove manual edit of generated file.

* Updating generated files for Azure Quantum data plane from new swagger file version

* Updating generated files for Azure Quantum resource manager from new swagger file version. (2020-11-06) (#13)

* Adding implementation of 'az quantum workspace create' command. (#14)

Adding initial implementation of 'az quantum workspace create' command.

-----------------------------------
Command
az quantum workspace create : Creates a new Azure Quantum workspace.
Command group 'quantum' is in preview. It may be changed/removed in a future
release.
Arguments
--location -l : Location. Values from: az account list-locations. You can configure
the default location using az configure --defaults location=<location>.
--resource-group -g : Name of resource group. You can configure the default group using az configure --defaults group=<name>.
--storage_account -sa : Name of the storage account to be used by a quantum workspace.
--workspace-name -w : Name of the Quantum Workspace. You can configure the default workspace
using az quantum workspace set.

* Update Azure CLI quantum extension to multi-region (#17)

This change will set the URL for the data plan API accordingly with a location parameter specified as part of the command.

* Updating swagger files per commit 44563991425d862ba4e8090a2b5b6caf8333600c in azure-rest-api-specs-pr. (#16)

Updating swagger files per commit 44563991425d862ba4e8090a2b5b6caf8333600c in azure-rest-api-specs-pr.

* Fixing tests for multi-region URL change on Az CLI quantum extension (#19)

Fixing tests for multi-region URL change on Az CLI quantum extension

* Incorporating ARM feedback  (#18)

* Picking up latest changes from swagger after ARM feedback

* updated create_or_update

* run command

* Setting default location in workspace calls if not specified (#20)

* updating python azure quantum rest client (#21)

* Update generated files from swagger file (Version 2021-01-11) (#22)

* Hot fixes on December 2020 release of Azure CLI extension (#23)

* Fixing issue with over specification of location
* Updating version information of extension

* Update CLI with generated clients from more recent swagger files (#24)

- Data plane updated to official swagger file (2021-01-11 19:01:32 UTC) on azure-rest-api-specs @ 98ae52b.

- Resource manager updated to candidate swagger file (2021-01-15 19:35:41 UTC) on anpaz:quantum/resource-manager @ a9a9e271c13500aa54fdbb1bcb656eb61d82d38b.

* Update src/quantum/README.rst

Co-authored-by: Feiyue Yu <[email protected]>

* Update src/quantum/README.rst

Co-authored-by: Feiyue Yu <[email protected]>

* Update src/quantum/README.rst

Co-authored-by: Feiyue Yu <[email protected]>

* Update src/quantum/README.rst

Co-authored-by: Feiyue Yu <[email protected]>

* Require location as a mandatory parameter in workspace specification (#25)

* Make location mandatory in commands
* Update test recordings

* Resetting the version history for the released version.

* Fix description of workspace clear command

* Updatig Readme file to RST format.

* Update Readme file per pull request comments.

* Fixing az quantum run and execute commands to include location parameter

* Performing role assignment on storage account on workspace creation. (#29)

* Add warning message about providers during workspace creation (#30)

* Enable command az quantum workspace quotas (#31)

* Removing extra space in Readme.rst

Co-authored-by: Feiyue Yu <[email protected]>

* Fix punctuation in Readme.rst

Co-authored-by: Feiyue Yu <[email protected]>

* Update src/quantum/README.rst

Co-authored-by: Feiyue Yu <[email protected]>

* Update src/quantum/azext_quantum/_params.py

Co-authored-by: Feiyue Yu <[email protected]>

* First round of code review feedback on Readme.rst

* Improve code readability on job commands

* Avoid IndexError in case of malformed URL

* Extended info on targetId parameter

* Add help to each individual command

* Reorganize sections in Readme.rst and merge in a single set of instructions.

* Static analysis fixes

* Fix CLI Linter errors

* Fix CLI Linter errors. Part 2

* Fix typo in show command.

* Fix show command for Linter

* Use standard name for show command method

* Modify workspace create test to skip role assignment

* Update tests with workspace names used currently.

* Update test recordings.

* Set subscription for the recordings.

* Update test recordings.

* Update QDK version number

* Remove asserts and checks for subscription

* Experiment: Remove check for preview subscription

* Refresh recordings with current test values.

* Update recordings after typo fix.

* Remove commented out API that references subscription

* Enable QuantumJobsScenarioTest.test_submit_args only on live mode

Co-authored-by: Ricardo Espinoza <[email protected]>
Co-authored-by: Feiyue Yu <[email protected]>
@bhushangholave bhushangholave mentioned this pull request Nov 11, 2021
Closed
FumingZhang pushed a commit to FumingZhang/azure-cli-extensions that referenced this pull request Aug 23, 2022
@pdaru
Merge pull request Azure#9 from pdaru/fleet-extension
9dd68b2 
add GET,PATCH commands & update tests
snehapar9 pushed a commit to snehapar9/azure-cli-extensions that referenced this pull request May 12, 2023
@daniv-msft
Merge pull request Azure#9 from daniv-msft/daniv/variousMinorUpdates
c67fd7b 
Various updates to clean the code or smoothen slightly the UX/help text
wangzelin007 pushed a commit to wangzelin007/azure-cli-extensions that referenced this pull request Jul 11, 2023
@PerfectChaos
Merge pull request Azure#9 from jddarby/chaos/installinstructions
b3573e8 
Update readme with install/bug reporting instructions
sardobi pushed a commit to sardobi/azure-cli-extensions that referenced this pull request Sep 11, 2024
@bavneetsingh16
Merge pull request Azure#9 from dimbleby/fix-proxy-order
ed169b3 
add_config_protected_settings parameters in wrong order
pjohari-ms pushed a commit to pjohari-ms/azure-cli-extensions that referenced this pull request Sep 18, 2024
Merge pull request Azure#9 from carjackson-msft/fixLineEndings
d2ac22d 
fix line endings to lf
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tamirkamara tamirkamara tamirkamara approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@derekbekoe @tamirkamara