Skip to content

Commit

Permalink
[Core] Use WAM as the default authentication method on Windows (#28085)
Browse files Browse the repository at this point in the history
  • Loading branch information
jiasli authored Feb 27, 2024
1 parent 69d4ceb commit da6cfe0
Show file tree
Hide file tree
Showing 6 changed files with 6 additions and 14 deletions.
4 changes: 2 additions & 2 deletions src/azure-cli-core/azure/cli/core/_profile.py
Original file line number Diff line number Diff line change
Expand Up @@ -856,8 +856,8 @@ def _create_identity_instance(cli_ctx, *args, **kwargs):
# EXPERIMENTAL: Use core.use_msal_http_cache=False to turn off MSAL HTTP cache.
use_msal_http_cache = cli_ctx.config.getboolean('core', 'use_msal_http_cache', fallback=True)

# PREVIEW: On Windows, use core.enable_broker_on_windows=true to use broker (WAM) for authentication.
enable_broker_on_windows = cli_ctx.config.getboolean('core', 'enable_broker_on_windows', fallback=False)
# On Windows, use core.enable_broker_on_windows=false to disable broker (WAM) for authentication.
enable_broker_on_windows = cli_ctx.config.getboolean('core', 'enable_broker_on_windows', fallback=True)
from .telemetry import set_broker_info
set_broker_info(enable_broker_on_windows)

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -21,13 +21,5 @@
<body>
<h3>You have logged into Microsoft Azure!</h3>
<p>You can close this window, or we will redirect you to the <a href="https://docs.microsoft.com/cli/azure/">Azure CLI documentation</a> in 1 minute.</p>
<h3>Announcements</h3>
<p>[Windows only] Azure CLI is collecting feedback on using the <a href="https://learn.microsoft.com/windows/uwp/security/web-account-manager">Web Account Manager</a> (WAM) broker for the login experience.</p>
<p>You may opt-in to use WAM by running the following commands:</p>
<code>
az config set core.enable_broker_on_windows=true<br>
az account clear<br>
az login
</code>
</body>
</html>
2 changes: 1 addition & 1 deletion src/azure-cli-core/setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@
'jmespath',
'knack~=0.11.0',
'msal-extensions~=1.0.0',
'msal[broker]==1.26.0',
'msal[broker]==1.27.0',
'msrestazure~=0.6.4',
'packaging>=20.9',
'paramiko>=2.0.8,<4.0.0',
Expand Down
2 changes: 1 addition & 1 deletion src/azure-cli/requirements.py3.Darwin.txt
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,7 @@ jsondiff==2.0.0
knack==0.11.0
MarkupSafe==2.0.1
msal-extensions==1.0.0
msal[broker]==1.26.0
msal[broker]==1.27.0
msrest==0.7.1
msrestazure==0.6.4
oauthlib==3.2.2
Expand Down
2 changes: 1 addition & 1 deletion src/azure-cli/requirements.py3.Linux.txt
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,7 @@ jsondiff==2.0.0
knack==0.11.0
MarkupSafe==2.0.1
msal-extensions==1.0.0
msal[broker]==1.26.0
msal[broker]==1.27.0
msrest==0.7.1
msrestazure==0.6.4
oauthlib==3.2.2
Expand Down
2 changes: 1 addition & 1 deletion src/azure-cli/requirements.py3.windows.txt
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,7 @@ jsondiff==2.0.0
knack==0.11.0
MarkupSafe==2.0.1
msal-extensions==1.0.0
msal[broker]==1.26.0
msal[broker]==1.27.0
msrest==0.7.1
msrestazure==0.6.4
oauthlib==3.2.2
Expand Down

0 comments on commit da6cfe0

Please sign in to comment.