{Core} Bump MSAL to 1.10.0 #17240
Merged
{Core} Bump MSAL to 1.10.0 #17240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jiasli
requested review from
evelyn-ys,
fengzhou-msft,
houk-ms,
jsntcy and
Juliehzl
as code owners
jiasli
commented
Mar 9, 2021
| @@ -51,7 +51,7 @@ | |||
| 'humanfriendly>=4.7,<10.0', | |||
| 'jmespath', | |||
| 'knack==0.8.0rc2', | |||
| 'msal~=1.9', | |||
| 'msal>=1.10.0,<2.0.0', | |||
There was a problem hiding this comment.
Given the stability of MSAL, we can relax it to <2.0.0. This is also what Azure Identity requires:
"msal<2.0.0,>=1.7.0",
fengzhou-msft
approved these changes
Mar 11, 2021
# Conflicts: # src/azure-cli-core/setup.py # src/azure-cli/requirements.py3.windows.txt
|
Core |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Bump MSAL to 1.10.0 so that AzureAD/microsoft-authentication-library-for-python#314 is fixed.
Symptom
When
https://management.azure.com/.default) doesn't require MFAhttps://pas.windows.net/CheckMyAccess/Linux/.default) requires MFAIn CLI beta, failure in
az ssh vm(#17147) will cause the RT of ARM in MSAL token cache to be removed, making subsequence ARM commands likeaz group listfail.Testing Guide
az login az ssh vm -g cli-dev --vm-name ubuntu-vm # Wait 1 hour so that AT expires az group listAdditional context
The change will be merged to
betabranch later.