Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

{Core} Python 3.11: Remove workaround for argparse that breaks on Python 3.11 #24109

Closed
wants to merge 1 commit into from
Closed

{Core} Python 3.11: Remove workaround for argparse that breaks on Python 3.11 #24109

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions src/azure-cli-core/azure/cli/core/parser.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
# --------------------------------------------------------------------------------------------

import difflib
import sys

import argparse
import argcomplete
Expand Down Expand Up @@ -91,8 +92,10 @@ def load_command_table(self, command_loader):

command_verb = command_name.split()[-1]
# To work around http://bugs.python.org/issue9253, we artificially add any new
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked http://bugs.python.org/issue9253 mentioned in the comment, but didn't see how it is related to this workaround.

# parsers we add to the "choices" section of the subparser.
subparser.choices[command_verb] = command_verb
# parsers we add to the "choices" section of the subparser. This workaround
# is no longer required in Python 3.11.
if sys.version_info < (3, 11):
subparser.choices[command_verb] = command_verb

# inject command_module designer's help formatter -- default is HelpFormatter
fc = metadata.formatter_class or argparse.HelpFormatter
Expand Down