{Network} Security - PL64k from NRP - Stable Swagger #29910
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
️✔️AzureCLI-FullTest
|
|
| rule | cmd_name | rule_message | suggest_message |
|---|---|---|---|
| network private-link-service create | cmd network private-link-service create added parameter destination_ip_address |
||
| network private-link-service create | cmd network private-link-service create update parameter lb_frontend_ip_configs: removed property required=True |
||
| network private-link-service update | cmd network private-link-service update added parameter destination_ip_address |
||
| network vnet create | cmd network vnet create added parameter private_endpoint_vnet_policies |
||
| network vnet list | cmd network vnet list added parameter pagination_limit |
||
| network vnet list | cmd network vnet list added parameter pagination_token |
||
| network vnet list-endpoint-services | cmd network vnet list-endpoint-services added parameter pagination_limit |
||
| network vnet list-endpoint-services | cmd network vnet list-endpoint-services added parameter pagination_token |
||
| network vnet update | cmd network vnet update added parameter private_endpoint_vnet_policies |
|
Network |
microsoft-github-policy-service
bot
requested review from
yonzhan,
jsntcy,
kairu-ms,
AllyW and
necusjz
microsoft-github-policy-service
bot
added
the
Network
cxznmhdcxz
force-pushed
the
Security-PL64k
branch
from
d3e4d8b
to
c45d77b
Compare
cxznmhdcxz
requested review from
zhoxing-ms,
wangzelin007,
yanzhudd,
evelyn-ys,
calvinhzy,
jiasli and
digimaun
as code owners
cxznmhdcxz
force-pushed
the
Security-PL64k
branch
2 times, most recently
from
79c7c88
to
df17b06
Compare
yonzhan
modified the milestones:
September 2024 (2024-10-08),
October 2024 (2024-11-05)
necusjz
previously approved these changes
Oct 8, 2024
calvinhzy
previously approved these changes
Oct 8, 2024
yanzhudd
reviewed
Oct 8, 2024
src/azure-cli/azure/cli/command_modules/appservice/tests/latest/sample_web/package.json
Outdated
Show resolved
Hide resolved
yanzhudd
reviewed
Oct 8, 2024
.../cli/command_modules/containerapp/tests/latest/data/source_built_using_acr_task/package.json
Outdated
Show resolved
Hide resolved
…r --destination-ip-address
cxznmhdcxz
force-pushed
the
Security-PL64k
branch
from
db4403b
to
a42158c
Compare
evelyn-ys
reviewed
Oct 8, 2024
| parameters: | ||
| private_endpoint_vnet_policies: | ||
| rule_exclusions: | ||
| - option_length_too_long |
There was a problem hiding this comment.
Can we add a short option for this parameter instead of using linter exclusion?
There was a problem hiding this comment.
added option name as --pe-vnet-policies
necusjz
approved these changes
Oct 9, 2024
kairu-ms
approved these changes
Oct 9, 2024
evelyn-ys
approved these changes
Oct 9, 2024
calvinhzy
approved these changes
Oct 9, 2024
yanzhudd
approved these changes
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related command
Description
https://msazure.visualstudio.com/One/_workitems/edit/28536618 with stable swagger
Testing Guide
History Notes
[Network]
az network vnet: Add--private-endpoint-vnet-policiesparameter[Network]
az network private-link-service: Add--destination-ip-addressparameterThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.