Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debian package: Pin cryptography version to 2.0 to fix WSL #4251

Merged
merged 1 commit into from
Aug 18, 2017

Conversation

derekbekoe
Copy link
Member

Addresses #4154.
Once merged, this change will come into affect for the next CLI release.

@codecov-io
Copy link

Codecov Report

Merging #4251 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4251   +/-   ##
=======================================
  Coverage   70.05%   70.05%           
=======================================
  Files         475      475           
  Lines       29614    29614           
  Branches     4541     4541           
=======================================
  Hits        20746    20746           
+ Misses       7424     7420    -4     
- Partials     1444     1448    +4
Impacted Files Coverage Δ
src/azure-cli-core/azure/cli/core/util.py 69.73% <0%> (ø) ⬆️
...dback/azure/cli/command_modules/feedback/custom.py 31.25% <0%> (ø) ⬆️
...nent/azure/cli/command_modules/component/custom.py 16.26% <0%> (ø) ⬆️
...li-cloud/azure/cli/command_modules/cloud/custom.py 13.79% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4d23492...d6c5a68. Read the comment docs.

@derekbekoe derekbekoe added this to the Sprint 21 milestone Aug 17, 2017
@derekbekoe
Copy link
Member Author

This should be merged before the next CLI release.
FYI @troydai @tjprescott @yugangw-msft

Copy link
Member

@tjprescott tjprescott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Is this issue posted in the cryptography repo or WSL?

@derekbekoe
Copy link
Member Author

Yes here - microsoft/WSL#2431

@derekbekoe derekbekoe merged commit bfe5e34 into Azure:master Aug 18, 2017
@derekbekoe derekbekoe deleted the wsl-debian branch August 18, 2017 21:35
@Hickory420
Copy link

Having the same issue with ansible-vault on WSL: Microsoft Windows [Version 10.0.15063]

Here is the stack trace:

$ echo -n "the plaintext to encrypt" | ansible-vault encrypt_string -vvv
No config file found; using defaults
New Vault password:
Confirm New Vault password:
Reading plaintext input from stdin. (ctrl-d to end input)
ERROR! Unexpected Exception: /home/hickory/.local/lib/python3.5/site-packages/cryptography/hazmat/bindings/_openssl.abi3.so: cannot enable executable stack as shared object requires: Invalid argument
the full traceback was:

Traceback (most recent call last):
  File "/home/hickory/.local/bin/ansible-vault", line 109, in <module>
    exit_code = cli.run()
  File "/home/hickory/.local/lib/python3.5/site-packages/ansible/cli/vault.py", line 158, in run
    self.execute()
  File "/home/hickory/.local/lib/python3.5/site-packages/ansible/cli/__init__.py", line 149, in execute
    fn()
  File "/home/hickory/.local/lib/python3.5/site-packages/ansible/cli/vault.py", line 269, in execute_encrypt_string
    outputs = self._format_output_vault_strings(b_plaintext_list)
  File "/home/hickory/.local/lib/python3.5/site-packages/ansible/cli/vault.py", line 299, in _format_output_vault_strings
    b_ciphertext = self.editor.encrypt_bytes(b_plaintext)
  File "/home/hickory/.local/lib/python3.5/site-packages/ansible/parsing/vault/__init__.py", line 415, in encrypt_bytes
    b_ciphertext = self.vault.encrypt(b_plaintext)
  File "/home/hickory/.local/lib/python3.5/site-packages/ansible/parsing/vault/__init__.py", line 209, in encrypt
    b_ciphertext = this_cipher.encrypt(b_plaintext, self.b_password)
  File "/home/hickory/.local/lib/python3.5/site-packages/ansible/parsing/vault/__init__.py", line 748, in encrypt
    b_key1, b_key2, b_iv = self._gen_key_initctr(b_password, b_salt)
  File "/home/hickory/.local/lib/python3.5/site-packages/ansible/parsing/vault/__init__.py", line 729, in _gen_key_initctr
    backend = default_backend()
  File "/home/hickory/.local/lib/python3.5/site-packages/cryptography/hazmat/backends/__init__.py", line 15, in default_backend
    from cryptography.hazmat.backends.openssl.backend import backend
  File "/home/hickory/.local/lib/python3.5/site-packages/cryptography/hazmat/backends/openssl/__init__.py", line 7, in <module>
    from cryptography.hazmat.backends.openssl.backend import backend
  File "/home/hickory/.local/lib/python3.5/site-packages/cryptography/hazmat/backends/openssl/backend.py", line 53, in <module>
    from cryptography.hazmat.bindings.openssl import binding
  File "/home/hickory/.local/lib/python3.5/site-packages/cryptography/hazmat/bindings/openssl/binding.py", line 13, in <module>
    from cryptography.hazmat.bindings._openssl import ffi, lib
ImportError: /home/hickory/.local/lib/python3.5/site-packages/cryptography/hazmat/bindings/_openssl.abi3.so: cannot enable executable stack as shared object requires: Invalid argument

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants