fix: validate that NCIDs are well-formed GUIDs #2359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thatmattlong
previously approved these changes
Nov 7, 2023
rbtr
added
cns
msvik
reviewed
Nov 7, 2023
rbtr
force-pushed
the
fix/validate-ncid-guid
branch
from
ac85f0d
to
3f0f746
Compare
Signed-off-by: Evan Baker <[email protected]>
Signed-off-by: Evan Baker <[email protected]>
Signed-off-by: Evan Baker <[email protected]>
rbtr
force-pushed
the
fix/validate-ncid-guid
branch
from
3f0f746
to
f93797d
Compare
msvik
approved these changes
Nov 7, 2023
rbtr
added a commit
that referenced
this pull request
Nov 8, 2023
* fix: validate that NCIDs are well-formed GUIDs Signed-off-by: Evan Baker <[email protected]> * fix tests Signed-off-by: Evan Baker <[email protected]> * add logs and test Signed-off-by: Evan Baker <[email protected]> --------- Signed-off-by: Evan Baker <[email protected]>
4 tasks
rbtr
added a commit
that referenced
this pull request
Nov 8, 2023
* fix: validate that NCIDs are well-formed GUIDs Signed-off-by: Evan Baker <[email protected]> * fix tests Signed-off-by: Evan Baker <[email protected]> * add logs and test Signed-off-by: Evan Baker <[email protected]> --------- Signed-off-by: Evan Baker <[email protected]>
rbtr
added a commit
that referenced
this pull request
Nov 8, 2023
* fix: validate that NCIDs are well-formed GUIDs * fix tests * add logs and test --------- Signed-off-by: Evan Baker <[email protected]>
rbtr
removed
the
needs-backport
matmerr
pushed a commit
that referenced
this pull request
Jan 17, 2024
* fix: validate that NCIDs are well-formed GUIDs Signed-off-by: Evan Baker <[email protected]> * fix tests Signed-off-by: Evan Baker <[email protected]> * add logs and test Signed-off-by: Evan Baker <[email protected]> --------- Signed-off-by: Evan Baker <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
Validate that the input requests are for valid NCIDs, otherwise don't attempt to process them.
Issue Fixed:
Requirements:
Notes: