Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: joining multiple dns server lists #2506

Merged
merged 3 commits into from
Jan 15, 2024
Merged

fix: joining multiple dns server lists #2506

merged 3 commits into from
Jan 15, 2024

Conversation

vakalapa
Copy link
Contributor

@vakalapa vakalapa commented Jan 15, 2024 •
edited
Loading

Reason for Change:

Earlier command was not setting DNS list but instead it was resolving the IP causing failures in CNI ADD, new change will set the DNS specifically

Issue Fixed:

Requirements:

Notes:

@vakalapa vakalapa requested a review from a team as a code owner January 15, 2024 09:16
@vakalapa vakalapa requested a review from kmurudi January 15, 2024 09:16
anubhabMajumdar
anubhabMajumdar approved these changes Jan 15, 2024
View reviewed changes
Copy link

@anubhabMajumdar anubhabMajumdar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@anubhabMajumdar anubhabMajumdar mentioned this pull request Jan 15, 2024
Closed
4 tasks
@vakalapa vakalapa added this pull request to the merge queue Jan 15, 2024
@vakalapa vakalapa removed this pull request from the merge queue due to a manual request Jan 15, 2024
@vakalapa vakalapa merged commit 34a26f7 into master Jan 15, 2024
14 checks passed
@vakalapa vakalapa deleted the vakr/fixdns branch January 15, 2024 17:16
MikeZappa87 added a commit that referenced this pull request Jan 16, 2024
@MikeZappa87
ci: setup cilium+hubble nightly run
a37866c 
deps: bump github.com/spf13/viper from 1.16.0 to 1.18.2 (#2495)

Bumps [github.com/spf13/viper](https://github.com/spf13/viper) from 1.16.0 to 1.18.2.
- [Release notes](https://github.com/spf13/viper/releases)
- [Commits](spf13/viper@v1.16.0...v1.18.2)

---
updated-dependencies:
- dependency-name: github.com/spf13/viper
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

change config to be uniform

ci: increase dependabot PR limit to 10 (#2497)

ci: constrain cilium to linux on Release Test Pipeline (#2489)

ci: constrain cilium to linux

ci: Improve CNI|NPM integration test (#2498)

* ci: increase timeout for CNI|NPM intergration test

* add: retry to generate NPM logs

deps: bump golang.org/x/sys from 0.15.0 to 0.16.0 (#2500)

Bumps [golang.org/x/sys](https://github.com/golang/sys) from 0.15.0 to 0.16.0.
- [Commits](golang/sys@v0.15.0...v0.16.0)

---
updated-dependencies:
- dependency-name: golang.org/x/sys
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

deps: bump github.com/prometheus/client_golang from 1.16.0 to 1.18.0 (#2501)

Bumps [github.com/prometheus/client_golang](https://github.com/prometheus/client_golang) from 1.16.0 to 1.18.0.
- [Release notes](https://github.com/prometheus/client_golang/releases)
- [Changelog](https://github.com/prometheus/client_golang/blob/main/CHANGELOG.md)
- [Commits](prometheus/client_golang@v1.16.0...v1.18.0)

---
updated-dependencies:
- dependency-name: github.com/prometheus/client_golang
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

deps: bump google.golang.org/protobuf from 1.31.0 to 1.32.0 (#2502)

Bumps google.golang.org/protobuf from 1.31.0 to 1.32.0.

---
updated-dependencies:
- dependency-name: google.golang.org/protobuf
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

deps: bump golang.org/x/crypto from 0.17.0 to 0.18.0 (#2492)

Bumps [golang.org/x/crypto](https://github.com/golang/crypto) from 0.17.0 to 0.18.0.
- [Commits](golang/crypto@v0.17.0...v0.18.0)

---
updated-dependencies:
- dependency-name: golang.org/x/crypto
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

deps: bump k8s.io/klog/v2 from 2.110.1 to 2.120.0 (#2503)

Bumps [k8s.io/klog/v2](https://github.com/kubernetes/klog) from 2.110.1 to 2.120.0.
- [Release notes](https://github.com/kubernetes/klog/releases)
- [Changelog](https://github.com/kubernetes/klog/blob/main/RELEASE.md)
- [Commits](kubernetes/klog@v2.110.1...v2.120.0)

---
updated-dependencies:
- dependency-name: k8s.io/klog/v2
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

ci: verbose output for make test-load  (#2481)

ci: make test-load verbose output

fix review comments

deps: bump google.golang.org/grpc from 1.59.0 to 1.60.1 (#2494)

Bumps [google.golang.org/grpc](https://github.com/grpc/grpc-go) from 1.59.0 to 1.60.1.
- [Release notes](https://github.com/grpc/grpc-go/releases)
- [Commits](grpc/grpc-go@v1.59.0...v1.60.1)

---
updated-dependencies:
- dependency-name: google.golang.org/grpc
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

ci: add OS scale timeout (#2490)

ci: add kubeproxy restart before windows k8s conformance testing (#2496)

* ci: ensure kubeproxy is running on windows

* ci: add set -e

Signed-off-by: John Payne <[email protected]>

---------

Signed-off-by: John Payne <[email protected]>

ci: Improve TestValidateState calls from load package (#2484)

* ci: improve TestValidateState

* chore: address comments

fix: joining multiple dns server lists (#2506)

* fix: joining multiple dns server lists

* address comments

* add 0 check

fix: downgrade k8s components to 1.28 (#2505)

Signed-off-by: GitHub <[email protected]>
MikeZappa87 added a commit that referenced this pull request Jan 16, 2024
@MikeZappa87
ci: setup cilium+hubble nightly run
25b36c5 
deps: bump github.com/spf13/viper from 1.16.0 to 1.18.2 (#2495)

Bumps [github.com/spf13/viper](https://github.com/spf13/viper) from 1.16.0 to 1.18.2.
- [Release notes](https://github.com/spf13/viper/releases)
- [Commits](spf13/viper@v1.16.0...v1.18.2)

---
updated-dependencies:
- dependency-name: github.com/spf13/viper
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

change config to be uniform

ci: increase dependabot PR limit to 10 (#2497)

ci: constrain cilium to linux on Release Test Pipeline (#2489)

ci: constrain cilium to linux

ci: Improve CNI|NPM integration test (#2498)

* ci: increase timeout for CNI|NPM intergration test

* add: retry to generate NPM logs

deps: bump golang.org/x/sys from 0.15.0 to 0.16.0 (#2500)

Bumps [golang.org/x/sys](https://github.com/golang/sys) from 0.15.0 to 0.16.0.
- [Commits](golang/sys@v0.15.0...v0.16.0)

---
updated-dependencies:
- dependency-name: golang.org/x/sys
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

deps: bump github.com/prometheus/client_golang from 1.16.0 to 1.18.0 (#2501)

Bumps [github.com/prometheus/client_golang](https://github.com/prometheus/client_golang) from 1.16.0 to 1.18.0.
- [Release notes](https://github.com/prometheus/client_golang/releases)
- [Changelog](https://github.com/prometheus/client_golang/blob/main/CHANGELOG.md)
- [Commits](prometheus/client_golang@v1.16.0...v1.18.0)

---
updated-dependencies:
- dependency-name: github.com/prometheus/client_golang
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

deps: bump google.golang.org/protobuf from 1.31.0 to 1.32.0 (#2502)

Bumps google.golang.org/protobuf from 1.31.0 to 1.32.0.

---
updated-dependencies:
- dependency-name: google.golang.org/protobuf
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

deps: bump golang.org/x/crypto from 0.17.0 to 0.18.0 (#2492)

Bumps [golang.org/x/crypto](https://github.com/golang/crypto) from 0.17.0 to 0.18.0.
- [Commits](golang/crypto@v0.17.0...v0.18.0)

---
updated-dependencies:
- dependency-name: golang.org/x/crypto
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

deps: bump k8s.io/klog/v2 from 2.110.1 to 2.120.0 (#2503)

Bumps [k8s.io/klog/v2](https://github.com/kubernetes/klog) from 2.110.1 to 2.120.0.
- [Release notes](https://github.com/kubernetes/klog/releases)
- [Changelog](https://github.com/kubernetes/klog/blob/main/RELEASE.md)
- [Commits](kubernetes/klog@v2.110.1...v2.120.0)

---
updated-dependencies:
- dependency-name: k8s.io/klog/v2
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

ci: verbose output for make test-load  (#2481)

ci: make test-load verbose output

fix review comments

deps: bump google.golang.org/grpc from 1.59.0 to 1.60.1 (#2494)

Bumps [google.golang.org/grpc](https://github.com/grpc/grpc-go) from 1.59.0 to 1.60.1.
- [Release notes](https://github.com/grpc/grpc-go/releases)
- [Commits](grpc/grpc-go@v1.59.0...v1.60.1)

---
updated-dependencies:
- dependency-name: google.golang.org/grpc
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

ci: add OS scale timeout (#2490)

ci: add kubeproxy restart before windows k8s conformance testing (#2496)

* ci: ensure kubeproxy is running on windows

* ci: add set -e

Signed-off-by: John Payne <[email protected]>

---------

Signed-off-by: John Payne <[email protected]>

ci: Improve TestValidateState calls from load package (#2484)

* ci: improve TestValidateState

* chore: address comments

fix: joining multiple dns server lists (#2506)

* fix: joining multiple dns server lists

* address comments

* add 0 check

fix: downgrade k8s components to 1.28 (#2505)

Signed-off-by: GitHub <[email protected]>
@jpayne3506
Copy link
Contributor

fixes #2327

@rbtr rbtr added cns Related to CNS. fix Fixes something. release/latest Change affects latest release train needs-backport Change needs to be backported to previous release trains labels Jan 16, 2024
jpayne3506 pushed a commit that referenced this pull request Jan 16, 2024
@vakalapa @jpayne3506
fix: joining multiple dns server lists (#2506)
970eb0e 
* fix: joining multiple dns server lists

* address comments

* add 0 check
@jpayne3506 jpayne3506 mentioned this pull request Jan 16, 2024
Merged
4 tasks
matmerr pushed a commit that referenced this pull request Jan 17, 2024
@vakalapa @matmerr
fix: joining multiple dns server lists (#2506)
27c8c9f 
* fix: joining multiple dns server lists

* address comments

* add 0 check
jpayne3506 pushed a commit that referenced this pull request Feb 15, 2024
@vakalapa @jpayne3506
fix: joining multiple dns server lists (#2506)
8ab25c8 
* fix: joining multiple dns server lists

* address comments

* add 0 check
jpayne3506 pushed a commit that referenced this pull request Mar 1, 2024
@vakalapa @jpayne3506
fix: joining multiple dns server lists (#2506)
37961e3 
* fix: joining multiple dns server lists

* address comments

* add 0 check
jpayne3506 pushed a commit that referenced this pull request Mar 5, 2024
@vakalapa @jpayne3506
fix: joining multiple dns server lists (#2506)
653a64a 
* fix: joining multiple dns server lists

* address comments

* add 0 check
jpayne3506 added a commit that referenced this pull request Mar 5, 2024
@jpayne3506 @vakalapa
backport: fix: joining multiple dns server lists (#2506) (#2516)
a5e3859 
fix: joining multiple dns server lists (#2506)

* fix: joining multiple dns server lists

* address comments

* add 0 check

Co-authored-by: Vamsi Kalapala <[email protected]>
@jpayne3506 jpayne3506 removed the needs-backport Change needs to be backported to previous release trains label Aug 20, 2024
@jpayne3506 jpayne3506 added the release/1.4 Change affects v1.4 release train label Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpayne3506 jpayne3506 jpayne3506 approved these changes

@anubhabMajumdar anubhabMajumdar anubhabMajumdar approved these changes

@kmurudi kmurudi Awaiting requested review from kmurudi kmurudi is a code owner automatically assigned from Azure/azure-sdn-members

Assignees

@jpayne3506 jpayne3506

Labels
cns Related to CNS. fix Fixes something. release/latest Change affects latest release train release/1.4 Change affects v1.4 release train
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vakalapa @jpayne3506 @anubhabMajumdar @rbtr