trying Diagram 2 with ContainerInternal instead of ContainerInlineCore

Azure · Sep 19, 2024 · 1b17ab7 · 1b17ab7
1 parent 35acb5f
commit 1b17ab7
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 30 deletions.
diff --git a/Microsoft.Azure.Cosmos/src/Resource/Container/Container.cs b/Microsoft.Azure.Cosmos/src/Resource/Container/Container.cs
@@ -1755,7 +1755,7 @@ public abstract Task<IEnumerable<string>> GetPartitionKeyRangesAsync(
         public abstract ChangeFeedProcessorBuilder GetChangeFeedProcessorBuilderWithAllVersionsAndDeletes<T>(
             string processorName,
             ChangeFeedHandler<ChangeFeedItem<T>> onChangesDelegate);
-#endif
+
         /// <summary>
         /// Determines whether the given child feed range is a subset of the specified parent feed range.
         /// </summary>
@@ -1781,18 +1781,13 @@ public abstract ChangeFeedProcessorBuilder GetChangeFeedProcessorBuilderWithAllV
         /// </code>
         /// </example>
         /// <returns>True if the child feed range is a subset of the parent feed range; otherwise, false.</returns>
-#if PREVIEW
-        public
-#else
-        internal
-#endif
-
-        virtual Task<bool> IsFeedRangePartOfAsync(
+        public virtual Task<bool> IsFeedRangePartOfAsync(
             Cosmos.FeedRange parentFeedRange,
             Cosmos.FeedRange childFeedRange,
             CancellationToken cancellationToken = default)
         {
             throw new NotImplementedException();
         }
+#endif
     }
 }
diff --git a/Microsoft.Azure.Cosmos/src/Resource/Container/ContainerCore.Items.cs b/Microsoft.Azure.Cosmos/src/Resource/Container/ContainerCore.Items.cs
@@ -1257,12 +1257,7 @@ private ChangeFeedProcessorBuilder GetChangeFeedProcessorBuilderPrivate(
                 applyBuilderConfiguration: changeFeedProcessor.ApplyBuildConfiguration).WithChangeFeedMode(mode);
         }
 
-#if PREVIEW
-        public
-#else
-        internal
-#endif
-         override async Task<bool> IsFeedRangePartOfAsync(
+        public override async Task<bool> IsFeedRangePartOfAsync(
             FeedRange parentFeedRange,
             FeedRange childFeedRange,
             CancellationToken cancellationToken = default)

diff --git a/Microsoft.Azure.Cosmos/src/Resource/Container/ContainerInlineCore.cs b/Microsoft.Azure.Cosmos/src/Resource/Container/ContainerInlineCore.cs
@@ -674,21 +674,5 @@ public override Task<ResponseMessage> DeleteAllItemsByPartitionKeyStreamAsync(
                 task: (trace) => base.DeleteAllItemsByPartitionKeyStreamAsync(partitionKey, trace, requestOptions, cancellationToken),
                 openTelemetry: new (OpenTelemetryConstants.Operations.DeleteAllItemsByPartitionKey, (response) => new OpenTelemetryResponse(response)));
         }
-
-#if PREVIEW
-        public
-#else
-        internal
-#endif
-        override Task<bool> IsFeedRangePartOfAsync(
-            Cosmos.FeedRange parentFeedRange,
-            Cosmos.FeedRange childFeedRange,
-            CancellationToken cancellationToken = default)
-        {
-            return base.IsFeedRangePartOfAsync(
-                parentFeedRange,
-                childFeedRange,
-                cancellationToken);
-        }
     }
 }
diff --git a/Microsoft.Azure.Cosmos/src/Resource/Container/ContainerInternal.cs b/Microsoft.Azure.Cosmos/src/Resource/Container/ContainerInternal.cs
@@ -151,6 +151,11 @@ public abstract Task<IEnumerable<string>> GetPartitionKeyRangesAsync(
         public abstract ChangeFeedProcessorBuilder GetChangeFeedProcessorBuilderWithAllVersionsAndDeletes<T>(
             string processorName,
             ChangeFeedHandler<ChangeFeedItem<T>> onChangesDelegate);
+
+        public abstract Task<bool> IsFeedRangePartOfAsync(
+            Cosmos.FeedRange parentFeedRange,
+            Cosmos.FeedRange childFeedRange,
+            CancellationToken cancellationToken = default);
 #endif
 
         public abstract class TryExecuteQueryResult