Skip to content

Commit

Permalink
[Internal] Direct Package: Adds version bump (#4120)
Browse files Browse the repository at this point in the history
* direct version bump

* Code changes to fix emulator tests to comply with direct release 3.31.5.

---------

Co-authored-by: Debdatta Kunda <[email protected]>
  • Loading branch information
NaluTripician and kundadebdatta authored Oct 13, 2023
1 parent 7db0aa0 commit 20547bc
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 5 deletions.
2 changes: 1 addition & 1 deletion Directory.Build.props
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
<ClientOfficialVersion>3.35.4</ClientOfficialVersion>
<ClientPreviewVersion>3.35.4</ClientPreviewVersion>
<ClientPreviewSuffixVersion>preview</ClientPreviewSuffixVersion>
<DirectVersion>3.31.4</DirectVersion>
<DirectVersion>3.31.5</DirectVersion>
<EncryptionOfficialVersion>2.0.3</EncryptionOfficialVersion>
<EncryptionPreviewVersion>2.0.3</EncryptionPreviewVersion>
<EncryptionPreviewSuffixVersion>preview</EncryptionPreviewSuffixVersion>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -276,10 +276,9 @@ public async Task CreateAndInitializeAsync_WithValidDatabaseAndContainer_ShouldO
.GetValue(loadBalancingPartition);

Assert.IsNotNull(openChannels);
Assert.AreEqual(48, openChannels.Count, "Here the expected value 48 rather explains how many time we call the" +
"LoadBalancingPartition.OpenChannelAsync(). The emulator by default returns 12 partitions, and each partition has 4 replicas," +
"and by behavior the emulator uses the same URI for eac of these replica, hence 12 * 4 = 48 times we call the OpenChannelAsync()." +
"In ideal world, the value should be 1, because for each unique URI, the OpenChannelAsync() call will just be 1.");
Assert.AreEqual(1, openChannels.Count, "Here the expected value 1 explains how many TCP connections were opened by the LoadBalancingPartition.OpenChannelAsync()." +
"The emulator by default returns 12 partitions, and each partition has 4 replicas, and by behavior the emulator uses the same URI for each of these replica," +
"hence 12 * 4 = 48 times we call the OpenChannelAsync(). However, the number of TCP connections established would be just one per each unique endpoint.");
Assert.AreEqual(openChannels.Count * maxRequestsPerConnection, channelCapacity);

Documents.Rntbd.LbChannelState channelState = openChannels.First();
Expand Down

0 comments on commit 20547bc

Please sign in to comment.