Exposed underlying CosmosElements on item QueryResponse<T> using gene… #1018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ric type parameter.
j82w
reviewed
Nov 18, 2019
j82w
previously approved these changes
Nov 18, 2019
- Switching to using 'as' rather than 'is' to save on reflection.
bchong95
reviewed
Nov 18, 2019
bchong95
previously approved these changes
Nov 18, 2019
- Changing 'as' and 'null' check to inline 'is'.
bchong95
previously approved these changes
Nov 19, 2019
- Trying to do the generic cast in all cases leads to CosmosElements being returned for QueryResponse<dynamic>.Resource and QueryResponse<object>.Resource, etc. - This gives us the least change to the behavior for users that might do these sorts of casts.
j82w
approved these changes
Nov 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Description
Exposed underlying CosmosElements on item QueryResponse using generic type parameter.
Type of change