Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ThroughputResponse.IsReplacePending #1023

Merged
merged 5 commits into from
Nov 20, 2019
Merged

Fix ThroughputResponse.IsReplacePending #1023

merged 5 commits into from
Nov 20, 2019

Conversation

wahyuen
Copy link
Contributor

@wahyuen wahyuen commented Nov 19, 2019

fix the value that is being retrieved when mapping ThoughputResponse.IsReplacePending

Pull Request Template

Description

This PR is to fix the value that is being retrieved when mapping ThoughputResponse.IsReplacePending as it is currently incorrectly attempting to read WFConstants.BackendHeaders.MinimumRUsForOffer

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Closing issues

Closes #1024

fix the value that is being retrieved when mapping ThoughputResponse.IsReplacePending
@msftclas
Copy link

msftclas commented Nov 19, 2019

CLA assistant check
All CLA requirements met.

j82w
j82w previously approved these changes Nov 19, 2019
@j82w
Copy link
Contributor

j82w commented Nov 19, 2019

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@wahyuen wahyuen dismissed stale reviews from kirankumarkolli and j82w via d583bc0 November 20, 2019 00:17
@j82w
Copy link
Contributor

j82w commented Nov 20, 2019

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@kirankumarkolli kirankumarkolli merged commit 07dcca0 into Azure:master Nov 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ThroughputResponse reads wrong header for IsReplacePending
4 participants