Fixed Distinct Encoding Bug #1060
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
j82w
reviewed
Nov 27, 2019
Microsoft.Azure.Cosmos/src/Query/Core/DistinctMap.UnorderedDistinctMap.cs
Outdated
Show resolved
Hide resolved
j82w
reviewed
Dec 2, 2019
j82w
reviewed
Dec 4, 2019
changelog.md
Outdated
| @@ -30,6 +30,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 | |||
| - [#1036](https://github.com/Azure/azure-cosmos-dotnet-v3/pull/1036) Fixed query responses to return null Content if it is a failure | |||
| - [#1045](https://github.com/Azure/azure-cosmos-dotnet-v3/pull/1045) Added stack trace and innner exception to CosmosException | |||
| - [#1050](https://github.com/Azure/azure-cosmos-dotnet-v3/pull/1050) Add mocking constructors to TransactionalBatchOperationResult | |||
| - [#1060](https://github.com/Azure/azure-cosmos-dotnet-v3/pull/1060) Fixed unicode encoding bug in DISTINCT queries. | |||
There was a problem hiding this comment.
3.5.0 is shipped please move this up to unreleased
sboshra
previously approved these changes
Dec 4, 2019
j82w
approved these changes
Dec 5, 2019
sboshra
approved these changes
Dec 6, 2019
sboshra
deleted the
users/brchon/DistributedQuery/DistinctEncodingBugFix
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed Distinct Encoding Bug
Description
DISTINCT queries had a bug when encoding unicode characters. Encoding.Utf8.GetBytes was being given the length in utf8 characters instead of the char count of the string.
Type of change
Please delete options that are not relevant.