Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Diagnostics: Including header size details for BadRequest with large headers #1075

Merged
merged 8 commits into from
Dec 6, 2019
Merged

Diagnostics: Including header size details for BadRequest with large headers #1075

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
597ab1b
For BadRequest with large headers this PR lists the header sizes.
kirankumarkolli Dec 3, 2019
4f84ddc
Including change log
kirankumarkolli Dec 3, 2019
ee5a9ae
Fixing UT
kirankumarkolli Dec 3, 2019
7a61f30
Removing UT (with public emulator UT doesn't work)
kirankumarkolli Dec 3, 2019
3ddbe44
Removing unnecessary usings
kirankumarkolli Dec 3, 2019
bc8ab99
Update Microsoft.Azure.Cosmos/src/GatewayStoreClient.cs
kirankumarkolli Dec 3, 2019
a701a1c
Update Microsoft.Azure.Cosmos/src/GatewayStoreClient.cs
kirankumarkolli Dec 3, 2019
912def7
Chanign from Append -> AppendLine
kirankumarkolli Dec 3, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 20 additions & 1 deletion Microsoft.Azure.Cosmos/src/GatewayStoreClient.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ namespace Microsoft.Azure.Cosmos
using System.Linq;
using System.Net.Http;
using System.Net.Http.Headers;
using System.Text;
using System.Threading;
using System.Threading.Tasks;
using Microsoft.Azure.Documents;
Expand Down Expand Up @@ -178,9 +179,27 @@ internal static async Task<DocumentClientException> CreateDocumentClientExceptio
}
else
{
StringBuilder context = new StringBuilder();
context.AppendLine(await responseMessage.Content.ReadAsStringAsync());

HttpRequestMessage requestMessage = responseMessage.RequestMessage;
if (requestMessage != null)
{
context.AppendLine($"RequestUri: {requestMessage.RequestUri.ToString()};");
context.AppendLine($"RequestMethod: {requestMessage.Method.Method};");

if (requestMessage.Headers != null)
{
foreach (KeyValuePair<string, IEnumerable<string>> header in requestMessage.Headers)
{
context.AppendLine($"Header: {header.Key} Length: {string.Join(",", header.Value).Length};");
}
}
}

String message = await responseMessage.Content.ReadAsStringAsync();
return new DocumentClientException(
message: message,
message: context.ToString(),
innerException: null,
responseHeaders: responseMessage.Headers,
statusCode: responseMessage.StatusCode,
Expand Down
9 changes: 9 additions & 0 deletions changelog.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,15 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).

## Unreleased
### Added



### Fixed

- [#1075](https://github.com/Azure/azure-cosmos-dotnet-v3/pull/1075) Including header size details for BadRequest with large headers



## 3.5.0 - TBD

Expand Down