Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix possible NullReferenceException on a TransactionalBatch code path #1086

Merged
merged 2 commits into from
Dec 10, 2019

Conversation

abhijitpai
Copy link
Contributor

Description

Ensure the TransactionalBatchResponse is formed even when the server returns some response with a body that isn't in the expected format.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

@kirankumarkolli
Copy link
Member

Can we also collect required context to troubleshoot if any such occurrences occur?

Copy link
Member

@kirankumarkolli kirankumarkolli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Waiting for tracing context

@kirankumarkolli
Copy link
Member

Resolved the comments offline.

@kirankumarkolli kirankumarkolli merged commit df298c4 into master Dec 10, 2019
@kirankumarkolli kirankumarkolli deleted the users/abpai/batchnull branch December 10, 2019 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants