-
Notifications
You must be signed in to change notification settings - Fork 492
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ResponseFactory: Add a response factory to the public API #1453
Conversation
This uses the default serializer, correct? So users with a custom one would still need to do it on their end. If it uses the default serializer, can we explain more why would you use this versus just calling the Type APIs? Sounds like it's a very specific scenario. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the ResponseFactory is exposed on CosmosClient, for Encryption we'd need to take in the client also as input apart from the Container. Can we avoid this by either exposing it on Container or else have a reverse traversal mechanism from Container up?
Pull Request Template
Description
This change refactors and exposes a factory to create the item and feed responses. This allows users to create the responses which is necessary if users want to create a custom wrapper for the container abstraction.
Type of change
Please delete options that are not relevant.