Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PartitionRoutingHelper: Fix ReadFeed ArgumentNullException due to container cache miss #1512

Merged
merged 5 commits into from
May 15, 2020

Conversation

kirankumarkolli
Copy link
Member

@kirankumarkolli kirankumarkolli commented May 13, 2020

ReadFeed with container cache misss will lead to NRE (from LINIQ).

Fix:

  1. Return expected payload so-that callers can retry (force-refresh)
  2. Avoid unnecessary array materializations (in simple paths, except reverse)
  3. Info log turned to warning for observability

@kirankumarkolli kirankumarkolli changed the title PartitionRoutingHelper: Fix missing cache miss PartitionRoutingHelper: Fix ReadFeed ArgumentNullException due to container cache miss May 14, 2020
bchong95
bchong95 previously approved these changes May 14, 2020
ealsur
ealsur previously approved these changes May 14, 2020
@kirankumarkolli kirankumarkolli dismissed stale reviews from ealsur and bchong95 via 11b5e34 May 14, 2020 18:50
@kirankumarkolli kirankumarkolli merged commit 46e8aca into master May 15, 2020
@kirankumarkolli kirankumarkolli deleted the users/kirankk/cache_miss_handling branch May 15, 2020 05:55
kirankumarkolli added a commit that referenced this pull request May 16, 2020
…tainer cache miss (#1512)

* Test commit to treat null as missing info.

* UT asserting the resolvedRangeInfo with null values

* Marking missing routing map as warning

* reverting unnecessary change

* Using named parameters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants