-
Notifications
You must be signed in to change notification settings - Fork 492
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Diagnostics: Add synchronization context Part 1 #1587
Diagnostics: Add synchronization context Part 1 #1587
Conversation
Microsoft.Azure.Cosmos/src/Diagnostics/CosmosClientSideRequestStatistics.cs
Show resolved
Hide resolved
Unrelated to this PR: Container has its own implementation for it. Refers to: Microsoft.Azure.Cosmos/src/Resource/ClientContextCore.cs:318 in b8bc976. [](commit_id = b8bc976, deletion_comment = False) |
Microsoft.Azure.Cosmos/src/Diagnostics/CosmosDiagnosticsContext.cs
Outdated
Show resolved
Hide resolved
@@ -309,7 +309,7 @@ public virtual Task<AccountProperties> ReadAccountAsync() | |||
/// <param name="id">The Cosmos database id</param> | |||
/// <remarks> | |||
/// <see cref="Database"/> proxy reference doesn't guarantee existence. | |||
/// Please ensure database exists through <see cref="CosmosClient.CreateDatabaseAsync(DatabaseProperties, int?, RequestOptions, CancellationToken)"/> | |||
/// Please ensure database exists through <see cref="CosmosClient.CreateDatabaseAsync(string, int?, RequestOptions, CancellationToken)"/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are there any mechanisms which we could use to get consistency?
Like referring real code snippet like in the public docs?
Non blocking but will immensely help forward.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was pointing to a real snippet of code, it's just an internal method.
* Diagnostic refactor for synchronization context * Added Database changes to give more context on how it will look for inline classes
Pull Request Template
Description
This is part 1 with mostly just the diagnostic context changes and the CosmosClient updated to use the new interface. Other classes will be done in follow up PRs.
Type of change
Please delete options that are not relevant.
Closing issues
Put closes #XXXX in your comment to auto-close the issue that your PR fixes (if such).
Assignee
Please add yourself as the assignee
Projects
Please add relevant projects so this issue can be properly tracked.