Performance: Fix OM hierarchy to use strings for relative paths instead of URI #1617
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kirankumarkolli
requested review from
bchong95,
FabianMeiswinkel,
khdang,
kirillg and
sboshra
as code owners
kirankumarkolli
changed the title
ealsur
previously approved these changes
Jun 13, 2020
j82w
previously approved these changes
Jun 15, 2020
# Conflicts: # Microsoft.Azure.Cosmos/tests/Microsoft.Azure.Cosmos.Tests/FeedRange/ReadFeedTokenIteratorCoreTests.cs
# Conflicts: # Microsoft.Azure.Cosmos/src/Handler/RequestInvokerHandler.cs
j82w
previously approved these changes
Jun 18, 2020
sboshra
reviewed
Jun 24, 2020
# Conflicts: # Microsoft.Azure.Cosmos/src/Resource/ClientContextCore.cs # Microsoft.Azure.Cosmos/src/Resource/Conflict/ConflictsCore.cs # Microsoft.Azure.Cosmos/src/Resource/Container/ContainerCore.cs # Microsoft.Azure.Cosmos/src/Resource/Permission/PermissionCore.cs # Microsoft.Azure.Cosmos/src/Resource/QueryResponses/ChangeFeedIteratorCore.cs # Microsoft.Azure.Cosmos/src/Resource/QueryResponses/ChangeFeedPartitionKeyResultSetIteratorCore.cs # Microsoft.Azure.Cosmos/src/Resource/Scripts/ScriptsCore.cs # Microsoft.Azure.Cosmos/src/Resource/User/UserCore.cs
j82w
previously approved these changes
Jul 1, 2020
j82w
approved these changes
Jul 2, 2020
kirankumarkolli
added a commit
that referenced
this pull request
Jul 11, 2020
…ad of URI (#1617) * Excluding unnecessary Uri from main line paths * Fixing the bug * Including missed optimization * Some more related refactoring * Unit test fixes * Contract just to exclude compiler generated attribute * Building emulator projects * Moving all exiting URI references also to string * Fixing build break * Marking RequestUriString readonly Co-authored-by: j82w <[email protected]>
|
Closing due to in-activity, pease feel free to re-open. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1.5% CPU loss observed through profiles.
Though URI is created Direct takes plain string and its a wasted CPU cycles.
Microbenchmark shows around 5-6% gain.
For real workload it might be close to 1% gain.
Summary of benchmark from 4core Linux .Net core 3.1.
