Subpartitioning: Refactors code to replace internal flags with preview flags for public preview #1952
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ilReddy/azure-cosmos-dotnet-v3 into users/nanarava/multihash
…ilReddy/azure-cosmos-dotnet-v3 into users/nanarava/multihash
SrinikhilReddy
changed the title
SrinikhilReddy
changed the title
SrinikhilReddy
changed the title
SrinikhilReddy
changed the title
SrinikhilReddy
changed the title
ealsur
reviewed
Oct 28, 2020
SrinikhilReddy
changed the title
|
Closing since there has been no update for over 30 days. Please re-open if necessary. |
|
This PR was closed because of a lack of Java support for subpartitioning. Java PR is now out, Azure/azure-sdk-for-java#18503. Reopening this PR for merge consideration. |
| @@ -11,7 +11,7 @@ namespace Microsoft.Azure.Cosmos | |||
| /// <summary> | |||
| /// Represents a partition key value list in the Azure Cosmos DB service. | |||
| /// </summary> | |||
| #if INTERNAL || SUBPARTITIONING | |||
| #if PREVIEW | |||
There was a problem hiding this comment.
Please cover in the code docs that its an ordered pk collection
kirankumarkolli
requested changes
Jan 29, 2021
Updating files for PR merge readiness
kirankumarkolli
previously approved these changes
Feb 12, 2021
j82w
approved these changes
Feb 12, 2021
This was referenced Mar 8, 2021
|
Closing due to in-activity, pease feel free to re-open. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable subpartitioning feature to be available as public preview.
Description
Replacing the existing internal preprocessor directives with preview for subpartitioning feature code.