Client Encryption : Adds integration with Cosmos SDK 3.15.0-preview #1956
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anujtoshniwal
requested review from
ealsur,
FabianMeiswinkel,
j82w,
kirankumarkolli,
kirillg and
sboshra
as code owners
j82w
changed the title
j82w
previously approved these changes
Oct 23, 2020
abhijitpai
reviewed
Oct 23, 2020
abhijitpai
reviewed
Oct 23, 2020
Microsoft.Azure.Cosmos.Encryption/src/EncryptionTransactionalBatchResponse.cs
Outdated
Show resolved
Hide resolved
bchong95
reviewed
Oct 23, 2020
| private readonly TransactionalBatchResponse response; | ||
| private bool isDisposed = false; | ||
|
|
||
| public EncryptionTransactionalBatchResponse(List<TransactionalBatchOperationResult> results, TransactionalBatchResponse response) |
There was a problem hiding this comment.
Take IReadOnlyList and make a copy so that this class doesn't carry state from it's caller.
bchong95
reviewed
Oct 23, 2020
| { | ||
| private readonly List<TransactionalBatchOperationResult> results; | ||
| private readonly TransactionalBatchResponse response; | ||
| private bool isDisposed = false; |
There was a problem hiding this comment.
no need to set to default of T
j82w
approved these changes
Oct 27, 2020
abhijitpai
approved these changes
Oct 27, 2020
|
Closing due to in-activity, pease feel free to re-open. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Description
Integration with latest Cosmos SDK 3.15.0-preview from Encryption package. Internals dependency is removed in the latest SDK, as a result have had to mirror some code.
Type of change