CosmosDiagnostics: Fixes IndexOutOfRangeException #2099
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
j82w
added
bug
j82w
requested review from
bchong95,
ealsur and
FabianMeiswinkel
as code owners
j82w
requested review from
khdang,
kirankumarkolli,
kirillg and
sboshra
as code owners
ealsur
previously approved these changes
Dec 29, 2020
| @@ -40,6 +40,7 @@ public async Task TestInitialize() | |||
| this.containerSettings = new ContainerProperties(id: Guid.NewGuid().ToString(), partitionKeyPath: PartitionKey); | |||
| ContainerResponse response = await this.database.CreateContainerAsync( | |||
| this.containerSettings, | |||
| throughput: 20000, | |||
There was a problem hiding this comment.
Does this change make any difference?
There was a problem hiding this comment.
It makes it where there is multiple logical partitions which should cause the race condition to be exposed during our testing runs.
There was a problem hiding this comment.
Will it impact the test durations?
There was a problem hiding this comment.
There was no noticeable difference when testing locally or in gates. It still drains the same number of items. Worst case is for some queries it might result in a extra read operation.
Microsoft.Azure.Cosmos/tests/Microsoft.Azure.Cosmos.EmulatorTests/CosmosDiagnosticsTests.cs
Outdated
Show resolved
Hide resolved
Microsoft.Azure.Cosmos/tests/Microsoft.Azure.Cosmos.EmulatorTests/CosmosDiagnosticsTests.cs
Outdated
Show resolved
Hide resolved
ealsur
approved these changes
Dec 30, 2020
kirankumarkolli
approved these changes
Jan 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Description
To avoid any IndexOutOfRangeException the CosmosDiagnostics is refactored to remove the AddRange call. This will avoid any indexing issues caused by the possibility of the CosmosDiagnosticsContext getting modified in another task at the same time it is getting append to a parent CosmosDiagnosticContext.
This should also help improve performance by reducing the number of copies required when combining multiple CosmosDiangosticsContext.
Type of change
Please delete options that are not relevant.
Closing issues
To automatically close an issue: closes #2075