Request Options : Adds fix to support injecting/appending custom headers into request via RequestOptions. #2371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kr-santosh
requested review from
ealsur,
FabianMeiswinkel,
j82w,
khdang,
kirankumarkolli,
kirillg,
neildsh and
sboshra
as code owners
anujtoshniwal
previously approved these changes
Apr 9, 2021
kr-santosh
changed the title
j82w
reviewed
Apr 9, 2021
Microsoft.Azure.Cosmos/tests/Microsoft.Azure.Cosmos.EmulatorTests/CosmosHeaderTests.cs
Outdated
Show resolved
Hide resolved
j82w
reviewed
Apr 9, 2021
abhijitpai
previously approved these changes
Apr 16, 2021
| /// Clone RequestOptions. | ||
| /// </summary> | ||
| /// <returns> cloned RequestOptions. </returns> | ||
| public RequestOptions ShallowCopy() |
There was a problem hiding this comment.
Is it needed as explicit contract?
There was a problem hiding this comment.
currently required , so that we retain the original user passed RequestOptions ... MemberwiseClone method is protected in the Object class hence exposing ShallowCopy function and to be explicit about it being a shallow copy....
There was a problem hiding this comment.
On the name: @j82w are there any guidelines from central SDK team for related such?
There was a problem hiding this comment.
I couldn't find any guideline in the central SDK team documentation.
abhijitpai
approved these changes
Apr 20, 2021
j82w
approved these changes
Apr 20, 2021
j82w
approved these changes
Apr 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR focuses on adding support to inject custom headers into requests via RequestOptions. This would allow customers to directly inject custom headers. (The RequestOptions.Properties is meant for the client context and is not meant for adding headers.)
Type of change
Closing issues
To automatically close an issue: closes #2265