Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UserAgent: Fixes UserAgent to have the correct number of clients #2552

Merged
merged 5 commits into from
Jun 15, 2021
Merged

UserAgent: Fixes UserAgent to have the correct number of clients #2552

merged 5 commits into from
Jun 15, 2021

Conversation

asketagarwal
Copy link
Contributor

This PR does 2 things

  1. Uses CosmosClient.numberOfClientsCreated as ClientId in the user agent string.
  2. Removes the SetFeatures method from UserAgentContainer and moves the logic to the constructor.

@j82w j82w changed the title UserAgent: Refactors UserAgentString's ClientId implementation UserAgent: Fixes UserAgent to have the correct number of clients Jun 15, 2021
j82w
j82w previously approved these changes Jun 15, 2021
View reviewed changes
j82w
j82w previously approved these changes Jun 15, 2021
View reviewed changes
@j82w j82w merged commit 10cb815 into master Jun 15, 2021
@j82w j82w deleted the users/askagarw/useragentfix branch June 15, 2021 16:43
@asketagarwal asketagarwal mentioned this pull request Jun 23, 2021
Merged
@j82w j82w mentioned this pull request Jun 24, 2021
Closed
j82w pushed a commit that referenced this pull request Jun 25, 2021
@asketagarwal
UserAgent: Fixes race condition in ClientId and max value for UserAge…
fd1b2b6 
…ntString (#2574)

Issue introduced in #2552

The cap on the ClientId was removed in the above PR, as a result there was a increase in size of the Kusto tables.
The ClientId is also being made thread safe by introducing a clientId ref for every CosmosClient instance
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@j82w j82w j82w approved these changes

@ealsur ealsur Awaiting requested review from ealsur

@FabianMeiswinkel FabianMeiswinkel Awaiting requested review from FabianMeiswinkel FabianMeiswinkel is a code owner

@khdang khdang Awaiting requested review from khdang khdang is a code owner

@kirankumarkolli kirankumarkolli Awaiting requested review from kirankumarkolli kirankumarkolli is a code owner

@kirillg kirillg Awaiting requested review from kirillg kirillg is a code owner

@neildsh neildsh Awaiting requested review from neildsh neildsh is a code owner

@sboshra sboshra Awaiting requested review from sboshra sboshra is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@asketagarwal @j82w