Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Diagnostics: Adds GetStartTimeUtc and GetFailedRequestCount #3268

Merged
merged 31 commits into from
Jul 13, 2022
Merged

Diagnostics: Adds GetStartTimeUtc and GetFailedRequestCount #3268

merged 31 commits into from
Jul 13, 2022

Conversation

SchintaMicrosoft
Copy link
Contributor

Pull Request Template

Description

Please include a summary of the change and which issue is fixed. Include samples if adding new API, and include relevant motivation and context. List any dependencies that are required for this change.

Type of change

Please delete options that are not relevant.

  • [] Bug fix (non-breaking change which fixes an issue)
  • [] New feature (non-breaking change which adds functionality)
  • [] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [] This change requires a documentation update

Closing issues

To automatically close an issue: closes #IssueNumber

github-actions[bot]
github-actions bot previously requested changes Jun 14, 2022
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please follow the required format: "[Internal] Category: (Adds|Fixes|Refactors|Removes) Description"

Internal should be used for PRs that have no customer impact. This flag is used to help generate the changelog to know which PRs should be included. Examples:
Diagnostics: Adds GetElapsedClientLatency to CosmosDiagnostics
PartitionKey: Fixes null reference when using default(PartitionKey)
[v4] Client Encryption: Refactors code to external project
[Internal] Query: Adds code generator for CosmosNumbers for easy additions in the future.

@ealsur ealsur changed the title Get Failed count and GetStartTime and TraceSummary implemented Diagnostics: Adds GetStartTimeUtc and GetFailedRequestCount Jun 14, 2022
ealsur
ealsur previously approved these changes Jun 14, 2022
View reviewed changes
@ealsur
Copy link
Member

ealsur commented Jun 14, 2022

@kirankumarkolli Can you review the public API changes?

FabianMeiswinkel
FabianMeiswinkel requested changes Jun 14, 2022
View reviewed changes
Copy link
Member

@FabianMeiswinkel FabianMeiswinkel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Breaking changes

@FabianMeiswinkel
Copy link
Member

FabianMeiswinkel commented Jun 14, 2022 •
edited
Loading

@kirankumarkolli Can you review the public API changes?

The public API needs to be changed - adding new abstract members to a public non-sealed class is a breaking change.

ealsur
ealsur previously approved these changes Jul 8, 2022
View reviewed changes
FabianMeiswinkel
FabianMeiswinkel previously approved these changes Jul 11, 2022
View reviewed changes
Copy link
Member

@FabianMeiswinkel FabianMeiswinkel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now.

@ealsur ealsur enabled auto-merge (squash) July 13, 2022 15:32
@ealsur ealsur mentioned this pull request Jul 13, 2022
Closed
@ealsur ealsur merged commit da32785 into master Jul 13, 2022
@ealsur ealsur deleted the users/schinta/2848FailedRequestCount branch July 13, 2022 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kirankumarkolli kirankumarkolli kirankumarkolli left review comments

@ealsur ealsur ealsur approved these changes

@FabianMeiswinkel FabianMeiswinkel FabianMeiswinkel left review comments

@github-actions GitHub Actions github-actions left review comments

@khdang khdang Awaiting requested review from khdang khdang is a code owner

@sboshra sboshra Awaiting requested review from sboshra sboshra is a code owner

@neildsh neildsh Awaiting requested review from neildsh neildsh is a code owner

@j82w j82w Awaiting requested review from j82w

@kirillg kirillg Awaiting requested review from kirillg kirillg is a code owner

@adityasa adityasa Awaiting requested review from adityasa adityasa is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@SchintaMicrosoft @ealsur @FabianMeiswinkel @kirankumarkolli