Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ClientRetryPolicy: Fixes behavior to Meta-data write operations in multimaster accounts #3466

Merged
merged 14 commits into from
Oct 4, 2022

Conversation

NaluTripician
Copy link
Contributor

Pull Request Template

Description

In the issue, for multimaster accounts where the LimitToEndpoint flag is set to true and the endpoint is specified to the non-hub region, all metadata write operations will fail because we are trying to perform a write on a non-bub region that does not have access to the master partition. The failure will be a 403.3 error and the current way the ClientRetryPolicy is set up, these metadata write operations will not retry as the enableEndpointDiscovery flag is set to false when LimitToEndpoint is true. In the LocationCache. By changing the behavior of the 'ClientRetryPolicy' to retry metadata write opeations and LocationCache to check to see if it is a retried metadata write operation and then to reroute to the hub region, this problem can be mitigated.

Type of change

Please delete options that are not relevant.

  • [] Bug fix (non-breaking change which fixes an issue)
  • [] New feature (non-breaking change which adds functionality)

Closing issues

To automatically close an issue: closes #3408

Copy link
Member

@ealsur ealsur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add tests to cover any changes to the files and behaviors and see the other comments, good starting point!

ealsur
ealsur previously approved these changes Sep 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Meta-data write operation routing to hub region
3 participants