ClientRetryPolicy: Fixes behavior to handling of 503 HTTP errors #3479
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NaluTripician
requested review from
khdang,
adityasa,
neildsh,
kirankumarkolli,
ealsur,
FabianMeiswinkel and
kirillg
as code owners
ealsur
reviewed
Sep 29, 2022
Microsoft.Azure.Cosmos/tests/Microsoft.Azure.Cosmos.Tests/ClientRetryPolicyTests.cs
Outdated
Show resolved
Hide resolved
Microsoft.Azure.Cosmos/tests/Microsoft.Azure.Cosmos.Tests/ClientRetryPolicyTests.cs
Outdated
Show resolved
Hide resolved
ealsur
requested changes
Sep 29, 2022
imanvt
reviewed
Sep 29, 2022
|
Great work with the quick turnaround on the fix for the regression. Left one minor comment |
ealsur
approved these changes
Sep 30, 2022
NaluTripician
restored the
users/nalutripician/503SubstatusHandeling
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Description
#3008 introduced a regression on the cross-region handling for 503s.
This PR added different substatus codes for 503s to identify different scenarios (was the 503 from client side connectivity issues, did the 503 came from the service, was it due to quorum loss, etc) which gives actionable details to components and consumers of these 503s.
But the
ClientRetryPolicywas not adjusted to reflect this behavior with the new combination of substatus codes, the code is still checking for substatus 0. Changed the behavior to handle the new 503 status codes along with tests to avoid future regressions.Type of change
Please delete options that are not relevant.
Closing issues
To automatically close an issue: closes #3478