Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Serialization: Fixes call to CosmosSerializer.FromStream on Gateway mode when EnableContentResponseOnWrite is false #3814

Merged
5 commits merged into from Apr 25, 2023
Merged

Serialization: Fixes call to CosmosSerializer.FromStream on Gateway mode when EnableContentResponseOnWrite is false #3814

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
ca2b739
Do not call serializer if ResponseMessage.Content is empty.
Apr 17, 2023
649ed77
Add unit test
Apr 18, 2023
17454ce
Update unit tests
Apr 18, 2023
47fd449
Remove unused usings
Apr 18, 2023
8c9aa6e
Merge branch 'master' into fix/3812
ealsur Apr 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions Microsoft.Azure.Cosmos/tests/Microsoft.Azure.Cosmos.Tests/CosmosJsonSerializerUnitTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ namespace Microsoft.Azure.Cosmos.Core.Tests
using System.Linq;
using System.Net;
using System.Text;
using Castle.Core.Internal;
ealsur marked this conversation as resolved.
Show resolved Hide resolved
using Microsoft.Azure.Cosmos.CosmosElements;
using Microsoft.Azure.Cosmos.Query.Core;
using Microsoft.Azure.Cosmos.Scripts;
Expand Down Expand Up @@ -182,6 +183,8 @@ public void ValidateResponseFactoryJsonSerializer()
// Verify all the user types use the user specified version
ItemResponse<ToDoActivity> itemResponseFromFactory = cosmosResponseFactory.CreateItemResponse<ToDoActivity>(itemResponse);
Assert.IsNotNull(itemResponseFromFactory.Diagnostics);
// Verify that FromStream is not called as the stream is empty
mockUserJsonSerializer.Verify(x => x.FromStream<ToDoActivity>(itemResponse.Content), Times.Never);
cosmosResponseFactory.CreateStoredProcedureExecuteResponse<ToDoActivity>(storedProcedureExecuteResponse);

// Throw if the setups were not called
Expand Down