Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Internal] Msdata/Direct: Refactors msdata/direct branch with latest v3 master and Cosmos.Direct Release v3.31.5 #4152

Merged

Conversation

kundadebdatta
Copy link
Member

Pull Request Template

Description

Code changes to sync up msdata/direct with latest v3 master and Cosmos.Direct release version 3.31.5.

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

ealsur and others added 30 commits October 27, 2022 16:43
#3517)

* Adding log lines

* More logs

* Debugging further

* Removing other builds

* And more debugging

* Wrong build parameters

* Wrong category

* Removing noise

* Fixing test

* Adding utils

* Adding test with client telemetry enabled

* Fixing leak in Client Telemetry Tests

* Reenabling test

* cpu monitor initialization

* Adding name details

* Undo another file
… BY queries with continuation (#3525)

* Revert performance regression caused by #1289

* Remove irrelevant comment

* Add a test for validating formatted filters for the target partition
…es (#3533)

* wip

* regenerated baseline

* add test

* fix test

Co-authored-by: Sourabh Jain <[email protected]>
* Remove starttime and id from diagnostics string

* Remove starttime and id from diagnostics string

* Update xml files for trace baseline tests

* Update xml files for trace baseline tests

* Update xml files for trace baseline tests

* Whitespaces update

* Changed starttime position based on code review

Co-authored-by: Matias Quaranta <[email protected]>
* Rough draft

* Some more changes

* Adding a new section

* Some more refinement

* Some changes 

Lets get the feedback

* Some MISC changes
* Bumped SDK version and changelog

* Added contracts file for 3.31.2
* Initial commit

* Update.

* Pull/Rebase

* Addressed comments.

* Build fix
…eGateway (#3556)

* Adding IdEncoding unit tests for ComputeGateway

* Reacting to code review feedback

* Updating md files
* Adding rid parsing

* Test

* Removing dead code

* Contract update
…ame is flowing to opentelemetry module (#3532)

* wip

* WIP

* Revert "WIP"

This reverts commit 71275de54b9e67fa54a37e79d450b9597e173934.

* Revert "wip"

This reverts commit 586fa9865cc3f40dabd7ef90fb3e0cf499a045bc.

* wip add containe and database info

* redesign how container and database name information flows into opne telemetry data

* test fix

* fix test

* fix tests

* fix typos

* baseline test fix

Co-authored-by: Sourabh Jain <[email protected]>
…ns (#3562)

* add flag in diagnostic options

* test fixes

* rename variable

* test fix

* add validation

* fix baseline

* test fix

Co-authored-by: Sourabh Jain <[email protected]>
…s in ServiceInterop (#3399)

* Don't default to BadRequestException in case of errors in ServiceInterop

* Incorporate code review feedback

* Fix build error

* fix up failing test
… OptimisticDirectExecution pipeline (#3510)

* Added tests to test different aspects of merge/split support with OptimisticDirectExecution pipeline. Tests check for gone exception handling, pipeline switching etc.

* Added gone exception simulation tests.

* Added new tests and improved test infra

* Removed ParalleContEvocation test. Fixed comments

* Removed CreateParallelCrossPartitionPipelineStateAsync() as it is not being used anymore

* Removed while loop in CreateDocumentContainerAsync()

* Fixed comments.

* Updated ExecuteGoneExceptionOnODEPipeline()

* Added type Assert for ExecuteGoneExceptionOnODEPipeline()

* Updated OptimisticDirectExecution pipeline abbreviation

* Updated TestBaseline folder with new xml
…on retry (#3555)

* Fixes to ReadThroughputAsync for databases with no provisioned throughput and null as request options

* fixed failure to ReadReplaceThroughputResponseTests

* Added Stream Method

* Ran UpdateContract.ps1

* Encryption implemtation

* Fixed spelling error

* Update Microsoft.Azure.Cosmos.Encryption/src/EncryptionDatabase.cs

Co-authored-by: Matias Quaranta <[email protected]>

* Variable name change

* Update Microsoft.Azure.Cosmos/src/Resource/Database/Database.cs

Co-authored-by: Matias Quaranta <[email protected]>

* Suggested Changes and fixes

* Removed manufactured ResponseMessage + nits

* Simplified PR

* nits

* nits

* initial changes TODO: Update tests

* updated tests

* nits'

* Ran UpdateContracts.ps1

* nits + requested changes

* Delete NuGet.Config

* Update Microsoft.Azure.Cosmos/src/HttpClient/CosmosHttpClientCore.cs

Co-authored-by: Matias Quaranta <[email protected]>

* Update Microsoft.Azure.Cosmos/src/HttpClient/HttpTimeoutPolicy.cs

Co-authored-by: Matias Quaranta <[email protected]>

* Update Microsoft.Azure.Cosmos/src/HttpClient/HttpTimeoutPolicy.cs

Co-authored-by: Matias Quaranta <[email protected]>

* Update Microsoft.Azure.Cosmos/src/HttpClient/HttpTimeoutPolicy.cs

Co-authored-by: Matias Quaranta <[email protected]>

* Use Cosmos Exception Factory, Simplified Tests

* removed unused code

* nits: removed unused code

* removed unused code

Co-authored-by: Matias Quaranta <[email protected]>
Co-authored-by: Nalu Tripician <[email protected]>
…ned elements (#3574)

* Do not maintain an independent count on QueryResponse that can go out of sync

* Add more test coverage for QueryResponse<T>.Count

* Output the correct count from CosmosElementSerializer when the input contains CosmosUndefined

* Add untyped tests for CosmosUndefined

* Remove commented code
Co-authored-by: Sourabh Jain <[email protected]>
* Trace: Fixes Tracing/diagnostics hour-times to 24Hours

* fixing baseline tests

Co-authored-by: Matias Quaranta <[email protected]>
* wip

* status code int and internal and client kind activity

* remove unused imports

* update baselines

* fix test

* fixed baseline tests

* fix tests

* update base tetss

Co-authored-by: Sourabh Jain <[email protected]>
* Add SqlAllScalarExpression to v3 DOM

* updated generated parser files

* Parsing for ALL

* Added tests for ALL and baselines

* Added more tests

* added new test, cleanup

* cleaning & fix typos

* fixed typo

* Added new baseline test file names to csproj file

* renamed AggregateAll to AggregateSubquery to accomodate FIRST and LAST later

* Added keywords for 'left' and 'right' and respective function calls

* fixed bug from last commit

* cleaning

* replace tabs with spaces

* cleaning
* Ensures that both Direct and Gateway connection modes are tested
* Validates that container read works with PermissionMode.Read (test was previously only validating that Delete was blocked - i.e. the negative case).
#3583)

* add tests for otel and custome listener

* clean up

* null pointer fix

* fix tets

* handle event generation also at operation level

* added documentation

* wip

* change event sourcename

* rename event Name

Co-authored-by: Sourabh Jain <[email protected]>
…le to be retried (#3607)

* data plane writes no longer failover on timeout

* removed duplication of test\
sourabh1007 and others added 16 commits October 9, 2023 18:38
…etry response (#4097)

* adding tets

* wip

* wip2

* fix code

* add tests

* fix test

* fix test

* remove consoles

* fix indent and remove unused imports

* internal to private rollback

* added docs

* removed unused imports

* added exception in message

* fix exception catching
…n names (#4016)

* Allow ComosClientOptions to take ApplicationRegion and ApplicationPreferredRegions in multiple region name formats.

This is a proposed fix for - #2330

* Address PR comment to avoid duplicating list of names.

* Remove the map table cache

The map table is only used on initialization, so there's no need to keep a cache of it for the lifetime of the application

* Only convert the region names when the client is initializing

The cache is created before converting all the names, so it only needs created once, but doesn't remain for the entire lifetime of the application

* Update tests

* Make RegionNameMapper an instantiable class

Instead of having a prepare/clear cache system on a static class, make RegionNameMapper a class that gets instantiated for use and let the ctor handle it.

* Remove debugging

* Update tests to actually test things

---------

Co-authored-by: Pradeep Chellappan <[email protected]>
Co-authored-by: Pradeep Chellappan <[email protected]>
Co-authored-by: Matias Quaranta <[email protected]>
Co-authored-by: Kiran Kumar Kolli <[email protected]>
* Fix traceid null exception issue

* Fixing merge conflicts

* Fixing merge conflicts

* Update script

* Code cleanup

* Updated change description

* updated comment description

* updated comment description

---------

Co-authored-by: Matias Quaranta <[email protected]>
* GA telemetry options and updated contract

* enabe requuest level option

* added request option in public contract
* direct version bump

* Code changes to fix emulator tests to comply with direct release 3.31.5.

---------

Co-authored-by: Debdatta Kunda <[email protected]>
* Update ServerSidePartitionedMetrics.cs

* Update ServerSidePartitionedMetrics.cs
* Added Upsert Trigger Operation Support

* updated contract

* fix test
* first draft

* updated changelog

* remove already released PRs

* updated pr links

* changelog and contract changes

* updated changelog

* updated changelog

* updated changelog

* remove 4071 from changelog as it should be internal PR

* removed an query internal log

* updated contracts
…4130)

* remove release variable

* revert build config variable change also
…Handling = Error on Json default settings when NotFound on Item operations. (#4125)

* issue 4115 initial checkin. need insight from issuer on reproducing this issue

* test refactoring and adding more coverage for other NotFound scenarios

* commit on some actionables

* setting JsonConvert.DefaultSettings to null so that other tests will not fail

* as requested, removed catches from test methods
* initial cleanup

* test updates - working

* cleanup

* more cleanup

* more

* whoops

* Add results to basline

* adding payload to xml

* some generics

* cleanup

* Add datamember serializer

* reorder functions and test fix

* tostring() update and add case

* fix payload

* fix datamembertest

* cleanup

* cleanup

* PR comment

---------

Co-authored-by: Matias Quaranta <[email protected]>
* Client Telemetry Release test fix

* get endpoint from env variable

* read client telemetry endpoint service from env

* updated yaml
@kundadebdatta kundadebdatta self-assigned this Oct 23, 2023
@kirankumarkolli kirankumarkolli merged commit 01d97e4 into msdata/direct Oct 24, 2023
5 checks passed
@kirankumarkolli kirankumarkolli deleted the users/kundadebdatta/update_msdata_direct_10_23_2023 branch October 24, 2023 05:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.