-
Notifications
You must be signed in to change notification settings - Fork 494
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GlobalEndpointManager: Fixes Unobserved and Unhandled Exception from Getting Thrown #4241
Merged
microsoft-github-policy-service
merged 6 commits into
master
from
users/kundadebdatta/3994_fix_unhandled_exception_in_endpoint_manager
Jan 31, 2024
Merged
GlobalEndpointManager: Fixes Unobserved and Unhandled Exception from Getting Thrown #4241
microsoft-github-policy-service
merged 6 commits into
master
from
users/kundadebdatta/3994_fix_unhandled_exception_in_endpoint_manager
Jan 31, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kundadebdatta
requested review from
khdang,
sboshra,
adityasa,
neildsh,
kirankumarkolli,
ealsur,
FabianMeiswinkel and
kirillg
as code owners
January 30, 2024 22:55
kirankumarkolli
approved these changes
Jan 30, 2024
FabianMeiswinkel
approved these changes
Jan 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…eption_in_endpoint_manager
ealsur
approved these changes
Jan 30, 2024
…eption_in_endpoint_manager
microsoft-github-policy-service
bot
deleted the
users/kundadebdatta/3994_fix_unhandled_exception_in_endpoint_manager
branch
January 31, 2024 16:54
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Description
catch
block within theRefreshDatabaseAccountInternalAsync
method to log unobserved exception instead of throwing them.Type of change
Please delete options that are not relevant.
Closing issues
To automatically close an issue: closes #3994