Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Query: Adds support for multi-value Group By query for LINQ #4481

Merged

Conversation

leminh98
Copy link
Contributor

@leminh98 leminh98 commented May 13, 2024

Pull Request Template

Description

This PR adds the ability to translate LINQ query to SQL query with multiple items in the SQL select clause. This is achieved through the value clause using NewExpression

Type of change

Please delete options that are not relevant.

  • [] Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • [] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [] This change requires a documentation update

Closing issues

To automatically close an issue: closes #IssueNumber

@bartelink
Copy link
Contributor

Semi-related issues in case they are easy to address in the same block of work:

Copy link
Contributor

@adityasa adityasa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🕐

Minh Le (from Dev Box) and others added 3 commits May 21, 2024 03:17
…added handling of multivalue case to call directly to leaf layer visitors, instead of going through the top level scalar expression visitor to avoid changing binding and context scope
adityasa
adityasa previously approved these changes Jun 26, 2024
Copy link
Contributor

@adityasa adityasa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

adityasa
adityasa previously approved these changes Jul 2, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot merged commit 5bba9a0 into master Jul 9, 2024
21 checks passed
@microsoft-github-policy-service microsoft-github-policy-service bot deleted the users/leminh/LINQGroupByMultiValue branch July 9, 2024 04:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-merge Enables automation to merge PRs QUERY
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants