-
Notifications
You must be signed in to change notification settings - Fork 494
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open Telemetry: Adds Batchsize and Rename Batch Operation name in Operation Trace #4622
Merged
microsoft-github-policy-service
merged 6 commits into
master
from
users/sourabhjain/batchsizeinotel
Aug 6, 2024
Merged
Open Telemetry: Adds Batchsize and Rename Batch Operation name in Operation Trace #4622
microsoft-github-policy-service
merged 6 commits into
master
from
users/sourabhjain/batchsizeinotel
Aug 6, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sourabh1007
requested review from
kirankumarkolli,
ealsur,
FabianMeiswinkel,
kirillg and
sboshra
as code owners
August 2, 2024 02:51
sourabh1007
force-pushed
the
users/sourabhjain/batchsizeinotel
branch
from
August 2, 2024 10:06
3ed23f5
to
c2b9be8
Compare
sourabh1007
force-pushed
the
users/sourabhjain/batchsizeinotel
branch
from
August 2, 2024 10:35
c2b9be8
to
d656ee0
Compare
Microsoft.Azure.Cosmos/src/Telemetry/OpenTelemetry/OpenTelemetryAttributes.cs
Show resolved
Hide resolved
|
sourabh1007
force-pushed
the
users/sourabhjain/batchsizeinotel
branch
from
August 4, 2024 02:12
38e2a7d
to
80340c6
Compare
sourabh1007
force-pushed
the
users/sourabhjain/batchsizeinotel
branch
4 times, most recently
from
August 5, 2024 11:15
040c2f1
to
0093762
Compare
sourabh1007
force-pushed
the
users/sourabhjain/batchsizeinotel
branch
from
August 5, 2024 11:46
0093762
to
1bdad8b
Compare
Microsoft.Azure.Cosmos/src/Telemetry/OpenTelemetry/OpenTelemetryCoreRecorder.cs
Show resolved
Hide resolved
...osmos/tests/Microsoft.Azure.Cosmos.EmulatorTests/Tracing/EndToEndTraceWriterBaselineTests.cs
Show resolved
Hide resolved
Microsoft.Azure.Cosmos/src/Telemetry/OpenTelemetry/OpenTelemetryResponse.cs
Show resolved
Hide resolved
...atorTests/BaselineTest/TestBaseline/EndToEndTraceWriterBaselineTests.BulkOperationsAsync.xml
Show resolved
Hide resolved
kirankumarkolli
approved these changes
Aug 6, 2024
FabianMeiswinkel
approved these changes
Aug 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
microsoft-github-policy-service
bot
deleted the
users/sourabhjain/batchsizeinotel
branch
August 6, 2024 10:12
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Cosmetic Changes:
Refer, https://opentelemetry.io/docs/specs/semconv/database/cosmosdb/
db.operation
=>db.operation.name
db.name
=>db.namespace
db.cosmosdb.container
=>db.collection.name
Functional Changes:
db.operation.batch.size
Type of change
Reference: #4553