LocationCache ConcurrentDict lock contention fix #558
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
V2 fix is in master is under PR review |
j82w
previously approved these changes
Jul 16, 2019
simplynaveen20
previously approved these changes
Jul 16, 2019
kirankumarkolli
dismissed stale reviews from simplynaveen20 and j82w
via
471e119
bartelink
reviewed
Jul 17, 2019
simplynaveen20
approved these changes
Jul 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
LocationCache used ConcurrentDictionay.Count which serializes through lock resulting in high resource contention.
Usage changes from ConcurrentDictionay.Count to ConcurrentDictionay.Any() which is lock free but not a snapshot.
Order of conditions reversed avoiding ConcurrentDictionay.Any() evaluation on every call.
Type of change
closes #553