Fixed SpatialPath serialization and compatibility with older index versions #614
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...oft.Azure.Cosmos/tests/Microsoft.Azure.Cosmos.EmulatorTests/Fluent/ContainerSettingsTests.cs
Outdated
Show resolved
Hide resolved
...oft.Azure.Cosmos/tests/Microsoft.Azure.Cosmos.EmulatorTests/Fluent/ContainerSettingsTests.cs
Show resolved
Hide resolved
kirankumarkolli
previously approved these changes
Jul 31, 2019
added 3 commits
August 1, 2019 07:24
…e it uses the Cosmos types for the serialization.
j82w
changed the title
...oft.Azure.Cosmos/tests/Microsoft.Azure.Cosmos.EmulatorTests/Fluent/ContainerSettingsTests.cs
Show resolved
Hide resolved
...ure.Cosmos/tests/Microsoft.Azure.Cosmos.EmulatorTests/Utils/NonPartitionedContainerHelper.cs
Outdated
Show resolved
Hide resolved
...ure.Cosmos/tests/Microsoft.Azure.Cosmos.EmulatorTests/Utils/NonPartitionedContainerHelper.cs
Show resolved
Hide resolved
simplynaveen20
approved these changes
Aug 1, 2019
kirankumarkolli
approved these changes
Aug 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Description
The indexing policy's include path index object was using a converter from the Direct dependency which was using the Document namespace object instead of the v3 Cosmos namespace types. This caused the conversion to fail and return random results. Ported the converter to github repo and updated it to use the v3 types.
Fixed Spatial indexes serialization. There was bug that caused it to get serialized with an extra property which the backend did not understand which caused a bad request.
Type of change
Please delete options that are not relevant.