Session being updated incorrectly on Gateway mode #769
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ealsur
changed the title
kirankumarkolli
previously approved these changes
Sep 5, 2019
|
For direct mode direct package upgrade is needed right? |
|
@kirankumarkolli Yes, Direct package upgrade is needed |
ausfeldt
approved these changes
Sep 5, 2019
kirankumarkolli
approved these changes
Sep 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When dealing with Exception-less responses (Conflict, NotFound, Precondition failed, Throttling), the GatewayStoreModel was updating the session token when it shouldn't be.
This PR adds the fix plus tests for both Exceptions and Exception-less scenarios.
Type of change
Please delete options that are not relevant.