TryExecuteQuery #837
Merged
TryExecuteQuery #837
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
j82w
reviewed
Sep 23, 2019
Microsoft.Azure.Cosmos/src/Resource/Container/ContainerCore.Items.cs
Outdated
Show resolved
Hide resolved
sboshra
reviewed
Oct 7, 2019
sboshra
reviewed
Oct 7, 2019
sboshra
reviewed
Oct 7, 2019
kirankumarkolli
requested changes
Oct 8, 2019
|
@bchong95 won;t it get solved by query wire protocol versioning and configuring SDK to use target version? |
kirankumarkolli
requested changes
Oct 21, 2019
There was a problem hiding this comment.
@bchong95 wont it get solved by query wire protocol versioning and configuring SDK to use target version?
|
There isn't any versioning or configuring here |
|
This is merely exposing a TryExecute variant of CreateDocumentQuery. They are calling into the same version of code. |
|
Is 'TryExecuteQuery' purely an optimization to avoid NotSupported exception? |
|
It also allows the caller to determine what queries they want to allow. |
kirankumarkolli
previously approved these changes
Oct 22, 2019
|
@bchong95 please refresh the description also with current state of PR. |
kirankumarkolli
previously approved these changes
Oct 23, 2019
j82w
approved these changes
Oct 24, 2019
j82w
pushed a commit
that referenced
this pull request
Oct 29, 2019
* allowed for retrieval of query plan without exception * wired query plan through the stack * wired a try execute function * added test * resolved iteration comments * removed contracts * added GROUP BY support * resolved iteration comments * added try execute query * added back methods that require private members
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TryExecuteQuery
Description
This PR adds support for a TryExecuteQuery method which will try to execute a query with a set of supported query features. If the query is supported than the method will return a QueryIterator. If the query is not supported than the method returns a QueryPlan instead.
The purpose of this method is to support SQL Query Compute Gateway. We are going to initially only support queries that don't require any distribution work and over time allow more queries. If the query is not supported than we will send back a bad request with the query plan as usual and allow the SDK to do the cross partition work. The method will also always return a QueryPlan even if the query is executable, since we might want to cache the query plan in the future.
Type of change
Please delete options that are not relevant.