-
Notifications
You must be signed in to change notification settings - Fork 494
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add client side request statistics to query diagnostics #877
Add client side request statistics to query diagnostics #877
Conversation
…y/diagnostic_client
Microsoft.Azure.Cosmos/src/Diagnostics/QueryAggregateDiagnostics.cs
Outdated
Show resolved
Hide resolved
...osoft.Azure.Cosmos/src/Query/Core/ExecutionContext/PipelinedDocumentQueryExecutionContext.cs
Show resolved
Hide resolved
@@ -153,15 +148,14 @@ internal sealed class ItemProducer | |||
|
|||
this.fetchSchedulingMetrics = new SchedulingStopwatch(); | |||
this.fetchSchedulingMetrics.Ready(); | |||
this.fetchExecutionRangeAccumulator = new FetchExecutionRangeAccumulator(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't this needed for the client side query metrics?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't this data already in the client side request statistic? That already has the start and end time of each connection. Having this seemed like duplicate diagnostics. If there is a benefit please let me know and I'll add it back.
Microsoft.Azure.Cosmos/src/Query/Core/QueryMetrics/QueryPageDiagnostics.cs
Outdated
Show resolved
Hide resolved
Microsoft.Azure.Cosmos/src/Query/Core/QueryMetrics/QueryPageDiagnostics.cs
Outdated
Show resolved
Hide resolved
Microsoft.Azure.Cosmos/src/Query/v3Query/CosmosQueryClientCore.cs
Outdated
Show resolved
Hide resolved
Microsoft.Azure.Cosmos/src/Query/v3Query/CosmosQueryClientCore.cs
Outdated
Show resolved
Hide resolved
…y/diagnostic_client
Pull Request Template
Description
Example:
Type of change
Please delete options that are not relevant.