Fix a bug causing query response to create a new stream for each content call #901
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y time content was called on query response.
bchong95
reviewed
Oct 12, 2019
| @@ -99,7 +99,7 @@ static class CosmosElementSerializer | |||
| /// <param name="resourceType">The resource type</param> | |||
| /// <param name="cosmosSerializationOptions">The custom serialization options. This allows custom serialization types like BSON, JSON, or other formats</param> | |||
| /// <returns>Returns a memory stream of cosmos elements. By default the memory stream will contain JSON.</returns> | |||
| internal static Stream ToStream( | |||
| internal static MemoryStream ToStream( | |||
There was a problem hiding this comment.
I see you have finally come to the dark side on Stream vs MemoryStream and their disposability :)
There was a problem hiding this comment.
I honestly would like to convert all streams to new Memory objects.
bchong95
reviewed
Oct 12, 2019
bchong95
previously approved these changes
Oct 12, 2019
added 2 commits
October 14, 2019 08:51
….com/Azure/azure-cosmos-dotnet-v3 into users/jawilley/query/optimize_stream
kirankumarkolli
previously approved these changes
Oct 14, 2019
kirankumarkolli
previously approved these changes
Oct 21, 2019
added 2 commits
October 21, 2019 06:48
kirankumarkolli
approved these changes
Oct 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Description
QueryResponse was creating a new stream for every Content call. This causes a big performance hit if Content is called multiple times for example if the user is checking for null. This caches the result and uses the same stream for every content call. It's a memory stream so it does not need to be disposed of.
Type of change
Please delete options that are not relevant.