Change Feed Processor support for user serializer #944
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kirankumarkolli
previously approved these changes
Nov 1, 2019
kirankumarkolli
previously approved these changes
Nov 1, 2019
kirankumarkolli
approved these changes
Nov 10, 2019
ealsur
added a commit
that referenced
this pull request
Nov 19, 2019
* Using internal serializer * Fixing mocks * Adding new test * Changelog * merge with master
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Description
The Processor was using the public API methods to access the leases, this meant that if the user customized the Serializer, those operations would hit the user serializer instead of the internal one.
This PR refactors the Processor lease operations to use our internal serializer while letting the user serializer handle changes.
Type of change
Please delete options that are not relevant.
Closing issues
References #865