CosmosQueryExecutionContextFactory Refactory #988
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bchong95
requested review from
j82w,
kirankumarkolli and
kirillg
as code owners
j82w
reviewed
Nov 12, 2019
Microsoft.Azure.Cosmos/src/Query/Core/ExecutionContext/LazyCosmosQueryExecutionContext.cs
Show resolved
Hide resolved
Microsoft.Azure.Cosmos/src/Query/Core/ExecutionContext/LazyCosmosQueryExecutionContext.cs
Show resolved
Hide resolved
Microsoft.Azure.Cosmos/src/Query/Core/ExecutionContext/LazyCosmosQueryExecutionContext.cs
Outdated
Show resolved
Hide resolved
Microsoft.Azure.Cosmos/tests/Microsoft.Azure.Cosmos.Tests/CosmosQueryUnitTests.cs
Outdated
Show resolved
Hide resolved
...Cosmos/src/Query/Core/ExecutionContext/CosmosQueryExecutionContextWithNameCacheStaleRetry.cs
Show resolved
Hide resolved
Microsoft.Azure.Cosmos/src/Query/Core/ExecutionContext/CosmosQueryExecutionContextFactory.cs
Outdated
Show resolved
Hide resolved
Microsoft.Azure.Cosmos/src/Query/Core/ExecutionContext/CosmosQueryExecutionContextFactory.cs
Show resolved
Hide resolved
j82w
reviewed
Nov 14, 2019
j82w
reviewed
Nov 15, 2019
Microsoft.Azure.Cosmos/src/Query/Core/Aggregation/AverageAggregator.cs
Outdated
Show resolved
Hide resolved
sboshra
reviewed
Nov 15, 2019
sboshra
reviewed
Nov 15, 2019
Microsoft.Azure.Cosmos/src/Query/Core/ExecutionContext/CosmosQueryExecutionContextFactory.cs
Outdated
Show resolved
Hide resolved
sboshra
reviewed
Nov 15, 2019
Microsoft.Azure.Cosmos/src/Query/Core/ExecutionContext/CosmosQueryExecutionContextFactory.cs
Outdated
Show resolved
Hide resolved
sboshra
reviewed
Nov 15, 2019
...Cosmos/src/Query/Core/ExecutionContext/CosmosQueryExecutionContextWithNameCacheStaleRetry.cs
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CosmosQueryExecutionContextFactory Refactory
Description
CosmosQueryExecutionContextFactorywas a class that was hard to reason over, had a lot of state, and was trying to do multiple things.The first change was that
CosmosQueryExecutionContextFactoryis now actually a factory and not an instance of theCosmosQueryExecutionContextthis eliminates a lot of state being mutated. Along with that I made InputParameters fully immutable.The second change was to break down the 3 things the factory was handling:
PipelineQueryExecutionContext.ExecuteNextAsyncis called.into 3 separate classes
CosmosQueryExecutionContextFactoryLazyCosmosQueryExecutionContextFactoryCosmosQueryExecutionContextWithNameCacheIsStaleRetry