Remove lib from tsconfig. Use reference directive for AsyncIterable #161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bterlson We should chat about this. I think it will be important for other libraries not to run into this same issue |
christopheranderson
approved these changes
Oct 24, 2018
christopheranderson
added
the
improvement
southpolesteve
force-pushed
the
remove-tsconfig.lib
branch
from
f3f2e8c
to
3b698f1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Shipping a library that specifies any built-in TS lib types is problematic as downstream consumers will also have to add that lib option to their tsconfig. We can work around this by using a triple-Slash directive instead. See microsoft/TypeScript#27416
@burkeholland I believe this should fix #127 without you having to specify
lib: ["esnext"]in your own repo