-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
don't retry writes #301
don't retry writes #301
Conversation
kushagraThapar
commented
Dec 19, 2019
- SDK will not retry on write operations on Timeout Exception.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please talk to HA folks to ensure this doesn't break failover support etc.
…/Azure/azure-cosmosdb-java into users/moderakh/dont-retry-writes
validateSuccess(shouldRetry, ShouldRetryValidator.builder() | ||
.nullException() | ||
.shouldRetry(true) | ||
.backOfTime(i > 0 ? Duration.ofMillis(ClientRetryPolicy.RetryIntervalInMS) : Duration.ZERO) | ||
.shouldRetry(false) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ideal to cover all test scenarios. Please doc explore any gaps and cover them
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.