This repository has been archived by the owner on Jan 28, 2022. It is now read-only.
Pin tooling versions #166
Merged
Pin tooling versions #166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lawrencegripper
commented
Feb 12, 2020
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@lawrencegripper - now that #152 is merged, are you ok to publish this? |
|
Will do, let me rebase now and push |
lawrencegripper
force-pushed
the
lg/pintoolingversions
branch
from
a2217f7
to
2971a18
Compare
|
Thanks @lawrencegripper - are you ok to mark as Ready for Review now? |
|
Just testing some stuff out atm, |
|
np - thanks for updating. (was just checking in case you'd made the update but not marked as ready for review.... not that I'd ever do something like that 😉) |
|
Was an issue my side, good to go with review. |
|
@Azadehkhojandi / @JasonTheDeveloper are you to have a review of this one? @EliiseS is working on some changes to the devcontainer for the load testing work and would be good to base them off this one. |
Azadehkhojandi
approved these changes
Mar 3, 2020
|
/azp run |
EliiseS
pushed a commit
to EliiseS/azure-databricks-operator
that referenced
this pull request
Mar 4, 2020
* Pin tooling versions. Remove unused golang tooling * Fix helm version pinning
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR pins the versions of tooling used in the devcontainer to ensure future builds of the container are reproducable.
The driver for this change was issues observed with
goplsandkubectlin another project.For
kubectlv1.17 change validation behavior which introduced a breaking change when using some scripts.For
goplsthe location of the files in the repo moved which caused the devcontainer to stop building correctly.I've raised this as draft as it would be good to get #152 in first so the devcontainer changes are built before being merged.