-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SourceGen] Add support for overriding binding property name #1130
Conversation
@@ -236,7 +236,7 @@ public Task<ImmutableArray<IFunctionMetadata>> GetFunctionMetadataAsync(string d | |||
name = 'blob', | |||
type = 'BlobTrigger', | |||
direction = 'In', | |||
blobPath = 'container2/%file%', | |||
path = 'container2/%file%', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This test has been changed to reflect that blob triggers should have an arg name of "path", not "blobPath". In line 201 above for the Blob output binding, we still keep the arg name "blobPath".
Blob bindings classess for reference.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good - just some minor suggestions.
/check-enforcer evaluate |
Issue describing the changes in this PR
resolves #1087
Pull request checklist
release_notes.md
Additional information
Example usage of the attribute that overrides binding property names.
On the issue thread you can find a comment on the design assumptions. Given the limitations of Roslyn analyzers, this design relies on the convention that attribute constructor parameter names will match the name of the property they are assigned to (matching is NOT case-sensitive).