[SourceGen] Handle default values in binding attributes #1131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jviau
reviewed
Oct 19, 2022
satvu
force-pushed
the
satvu/handle-default-binding-values-sourcegen
branch
from
8d65547
to
5dd7a7a
Compare
jviau
reviewed
Oct 24, 2022
jviau
approved these changes
Oct 26, 2022
jviau
reviewed
Oct 26, 2022
satvu
force-pushed
the
satvu/handle-default-binding-values-sourcegen
branch
from
10c8a5a
to
e235854
Compare
jviau
approved these changes
Nov 2, 2022
|
/check-enforcer evaluate |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue describing the changes in this PR
resolves #1101
Pull request checklist
release_notes.mdCurrently, only EventHubsTrigger has a property with "DefaultValue" on it. This PR additionally standardizes casing for bindings on the source-generated file by choosing PascalCase when creating fields on the anonymous types we represent bindings with (before serializing them).
Values taken from properties with DefaultValue attributes keep their casing, and values whose names come from constructor parameters will uppercase the first letter.