-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove HttpStatusCode=OK from WriteAsJsonAsync #2720
Merged
Merged
+16
−94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabiocav
reviewed
Sep 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@RohitRanjanMS can you please update the release notes with the change details?
soninaren
approved these changes
Sep 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you update the release notes before merging.
fabiocav
pushed a commit
that referenced
this pull request
Oct 11, 2024
* WriteAsJsonAsync HttpStatusCode Fix
brettsam
pushed a commit
that referenced
this pull request
Oct 21, 2024
* WriteAsJsonAsync HttpStatusCode Fix
fabiocav
pushed a commit
that referenced
this pull request
Oct 21, 2024
* WriteAsJsonAsync HttpStatusCode Fix
fabiocav
pushed a commit
that referenced
this pull request
Oct 21, 2024
* WriteAsJsonAsync HttpStatusCode Fix
fabiocav
pushed a commit
that referenced
this pull request
Nov 11, 2024
* WriteAsJsonAsync HttpStatusCode Fix
fabiocav
pushed a commit
that referenced
this pull request
Nov 13, 2024
* WriteAsJsonAsync HttpStatusCode Fix
fabiocav
pushed a commit
that referenced
this pull request
Nov 13, 2024
* WriteAsJsonAsync HttpStatusCode Fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Eliminated the default value for HttpStatusCode and removed the overloaded methods for setting HttpStatusCode in the response.
Default Behavior - 200 OK
Return a non-200 response
resolves #776
This is a breaking change, targeting feature/2.x branch.
Pull request checklist
release_notes.md