Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Black-ing and isort-ing the azure_functions_worker #988

Closed
wants to merge 10 commits into from

Conversation

vrdmr
Copy link
Member

@vrdmr vrdmr commented Mar 21, 2022

Description

Cleaning up code by introducing Black and isort to the source. This is first of the series of PRs to move out of the setuptools to build.

Also to introduce structure in the code process. Some good example references:
wntrblm/nox#458


PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which has an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • If applicable, the PR references the bug/issue that it fixes in the description.
  • New Unit tests were added for the changes made and CI is passing.

Quality of Code and Contribution Guidelines

@vrdmr vrdmr marked this pull request as draft March 21, 2022 06:32
@codecov
Copy link

codecov bot commented Mar 21, 2022

Codecov Report

Merging #988 (2c68813) into dev (300cf00) will decrease coverage by 50.37%.
The diff coverage is 32.53%.

❗ Current head 2c68813 differs from pull request most recent head fee8fe2. Consider uploading reports for the commit fee8fe2 to get more accurate results

@@             Coverage Diff             @@
##              dev     #988       +/-   ##
===========================================
- Coverage   82.76%   32.39%   -50.38%     
===========================================
  Files          33       33               
  Lines        1677     1664       -13     
  Branches      267      267               
===========================================
- Hits         1388      539      -849     
- Misses        226     1124      +898     
+ Partials       63        1       -62     
Flag Coverage Δ
unittests 32.39% <32.53%> (-50.38%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
azure_functions_worker/__main__.py 0.00% <ø> (ø)
azure_functions_worker/bindings/out.py 57.14% <ø> (-42.86%) ⬇️
...ed_memory_data_transfer/shared_memory_exception.py 66.66% <ø> (-33.34%) ⬇️
...red_memory_data_transfer/shared_memory_metadata.py 50.00% <ø> (-50.00%) ⬇️
azure_functions_worker/main.py 0.00% <0.00%> (ø)
azure_functions_worker/bindings/datumdef.py 18.62% <3.84%> (-45.10%) ⬇️
azure_functions_worker/functions.py 19.53% <10.52%> (-73.50%) ⬇️
azure_functions_worker/dispatcher.py 19.83% <14.54%> (-69.87%) ⬇️
azure_functions_worker/utils/dependency.py 33.08% <24.13%> (-57.15%) ⬇️
azure_functions_worker/bindings/generic.py 48.48% <28.57%> (-39.40%) ⬇️
... and 46 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 300cf00...fee8fe2. Read the comment docs.

@vrdmr vrdmr closed this Jul 15, 2022
@vrdmr vrdmr deleted the vameru/black-isort-2 branch September 17, 2022 02:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants