Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adopt fluent theme for json schema from #616

Merged
merged 3 commits into from
Mar 13, 2023
Merged

Conversation

YingXue
Copy link
Member

@YingXue YingXue commented Mar 9, 2023

One drawback is that we have to temporarily enable npm ci --force, as rjsf has not updated its fluent dependency from 7 to 8, and we have an accessibility dependency on fluent 8. Tracking the issue here: rjsf-team/react-jsonschema-form#3463

  • If introducing new functionality or modified behavior, are they backed by unit tests?
  • Have all unit tests passed locally? (by running npm run test command)
  • Have you updated the README.md with new screenshots if significant changes have been made?
  • Have you update the package version if the current version in package.json is not higher than the version released?

@YingXue YingXue requested a review from Elsie4ever March 9, 2023 00:31
@YingXue YingXue changed the title adpot fluent team plugin for json schema from adopt fluent team plugin for json schema from Mar 9, 2023
@YingXue YingXue force-pushed the rjsfFluent branch 2 times, most recently from 3fb7be8 to 0b4d418 Compare March 10, 2023 04:48
@YingXue YingXue changed the title adopt fluent team plugin for json schema from adopt fluent theme for json schema from Mar 10, 2023
@YingXue YingXue merged commit 6207b36 into Azure:main Mar 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants